fix(npm): add 15 missing npm subcommands to prevent incorrect run injection (fixes #2663)#2677
Open
jlaportebot wants to merge 2 commits into
Open
fix(npm): add 15 missing npm subcommands to prevent incorrect run injection (fixes #2663)#2677jlaportebot wants to merge 2 commits into
jlaportebot wants to merge 2 commits into
Conversation
Author
|
All CI checks passing (CLA signed, check-target skipped). PR ready for merge. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #2663
Changes
Added 15 missing official npm subcommands to constant in :
completioneditexplorefind-dupeshelp-searchhookinstall-ci-testinstall-testlllsorgqueryrun-scriptrunsbomshrinkwrapunstarTesting
running 1 test
test cmds::js::npm_cmd::tests::test_npm_subcommand_routing ... ok
test result: ok. 1 passed; 0 failed; 0 ignored; 0 measured; 2244 filtered out; finished in 0.00s
running 0 tests
test result: ok. 0 passed; 0 failed; 0 ignored; 0 measured; 4 filtered out; finished in 0.00s
running 0 tests
test result: ok. 0 passed; 0 failed; 0 ignored; 0 measured; 10 filtered out; finished in 0.00s
running 0 tests
test result: ok. 0 passed; 0 failed; 0 ignored; 0 measured; 6 filtered out; finished in 0.00s
running 0 tests
test result: ok. 0 passed; 0 failed; 0 ignored; 0 measured; 14 filtered out; finished in 0.00s
running 0 tests
test result: ok. 0 passed; 0 failed; 0 ignored; 0 measured; 5 filtered out; finished in 0.00s
running 0 tests
test result: ok. 0 passed; 0 failed; 0 ignored; 0 measured; 11 filtered out; finished in 0.00s)
Impact
Users can now run , , , etc. without incorrect
runinjection.