perf(deps): move regex compilation to lazy_static#2689
Open
guyoron1 wants to merge 1 commit into
Open
Conversation
Three Regex::new() calls in deps.rs used static patterns but were compiled inside function bodies, causing recompilation on every invocation of summarize_cargo_str and summarize_requirements_str. Move all three to a lazy_static! block at module scope so they compile once at first use. Fixes rtk-ai#2688
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Three
Regex::new()calls indeps.rsuse static patterns but were compiledinside function bodies (
summarize_cargo_str,summarize_requirements_str),causing recompilation on every invocation.
Moves all three to a
lazy_static!block at module scope so they compile onceat first use, following the established RTK convention.
Changes
src/cmds/system/deps.rs: Moveddep_re,section_re, and requirementsdep_retolazy_static!block asCARGO_DEP_RE,CARGO_SECTION_RE, andREQUIREMENTS_DEP_RETest plan
cargo fmt --all— no formatting issuescargo clippy --all-targets— no warningscargo test --all— all tests passFixes #2688