feat: hook bypass: $(...) subshell, backticks, and xargs <cmd> skip#2693
Open
wilmerdooley wants to merge 1 commit into
Open
feat: hook bypass: $(...) subshell, backticks, and xargs <cmd> skip#2693wilmerdooley wants to merge 1 commit into
$(...) subshell, backticks, and xargs <cmd> skip#2693wilmerdooley wants to merge 1 commit into
Conversation
Signed-off-by: wilmerdooley <wilmerdooley1@gmail.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Resolves #2145.
The
rtk hook claudePreToolUse rewriter correctly handles top-level commands and common compound forms (|,;,&&) but bypasses three runtime-resolved patterns. Result: commands that should be rewritten ship as bare invocations, leaking token savings.Summary
Test plan
cargo fmt --all && cargo clippy --all-targets && cargo testrtk <command>output inspected