refactor(update): ensure temp directory cleared on failure

Author: rtuszik

src/update.py

@@ -177,15 +177,17 @@ def run_update(strategy: str):
 
     prepare_temp_dir()
 
-    download_url = get_download_url()
-    _ensure_disk_space(download_url, parallel=strategy == "PARALLEL")
+    try:
+        download_url = get_download_url()
+        _ensure_disk_space(download_url, parallel=strategy == "PARALLEL")
 
-    index_file = _download_verified_index()
+        index_file = _download_verified_index()
 
-    extract_index(index_file)
+        extract_index(index_file)
 
-    logging.info("Activating new index")
-    index.activate(os.path.join(config.TEMP_DIR, "photon_data"))
-    clear_temp_dir()
+        logging.info("Activating new index")
+        index.activate(os.path.join(config.TEMP_DIR, "photon_data"))
 
-    logging.info("Update pipeline completed successfully.")
+        logging.info("Update pipeline completed successfully.")
+    finally:
+        clear_temp_dir()

tests/test_update.py

@@ -321,6 +321,28 @@ def boom():
         update.run_update("SEQUENTIAL")
 
 
+def test_run_update_clears_temp_dir_on_failure(fake_dirs: Path, monkeypatch: pytest.MonkeyPatch):
+    monkeypatch.setattr(config, "SKIP_MD5_CHECK", True)
+    _make_pipeline_patches(monkeypatch)
+
+    cleared = {"n": 0}
+
+    def fake_clear():
+        cleared["n"] += 1
+
+    monkeypatch.setattr(update, "clear_temp_dir", fake_clear)
+
+    def boom():
+        raise update.DownloadError("download died")
+
+    monkeypatch.setattr(update, "download_index", boom)
+
+    with pytest.raises(update.DownloadError, match="download died"):
+        update.run_update("SEQUENTIAL")
+
+    assert cleared["n"] == 1
+
+
 def test_run_update_checksum_mismatch_prevents_activation(fake_dirs: Path, monkeypatch: pytest.MonkeyPatch):
     monkeypatch.setattr(config, "SKIP_MD5_CHECK", False)
     _make_pipeline_patches(monkeypatch)