From ff3314603c2fb28ad3efe9ad62ce01ca636bb889 Mon Sep 17 00:00:00 2001 From: Tobias Egli Date: Wed, 1 Apr 2026 09:09:53 +0200 Subject: [PATCH 1/3] Use config values instead of hardcoded credentials in broker spec --- spec/hutch/broker_spec.rb | 6 +++--- 1 file changed, 3 insertions(+), 3 deletions(-) diff --git a/spec/hutch/broker_spec.rb b/spec/hutch/broker_spec.rb index 287139f..236ae61 100644 --- a/spec/hutch/broker_spec.rb +++ b/spec/hutch/broker_spec.rb @@ -95,7 +95,7 @@ context 'when configured with a URI' do context 'which specifies the port' do - before { config[:uri] = 'amqp://guest:guest@127.0.0.1:5672/' } + before { config[:uri] = "amqp://#{config[:mq_username]}:#{config[:mq_password]}@#{config[:mq_host]}:#{config[:mq_port]}/" } it 'successfully connects' do c = broker.open_connection @@ -105,7 +105,7 @@ end context 'which does not specify port and uses the amqp scheme' do - before { config[:uri] = 'amqp://guest:guest@127.0.0.1/' } + before { config[:uri] = "amqp://#{config[:mq_username]}:#{config[:mq_password]}@#{config[:mq_host]}/" } it 'successfully connects' do c = broker.open_connection @@ -115,7 +115,7 @@ end context 'which specifies the amqps scheme' do - before { config[:uri] = 'amqps://guest:guest@127.0.0.1/' } + before { config[:uri] = "amqps://#{config[:mq_username]}:#{config[:mq_password]}@#{config[:mq_host]}/" } it 'utilises TLS' do expect(Hutch::Adapter).to receive(:new).with( From 919633fc41957bf828ad2ac89a6dc018c65c1a66 Mon Sep 17 00:00:00 2001 From: Tobias Egli Date: Wed, 1 Apr 2026 09:37:18 +0200 Subject: [PATCH 2/3] Migrate from ddtrace to datadog gem --- Gemfile | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/Gemfile b/Gemfile index 15e9d38..8f478c8 100644 --- a/Gemfile +++ b/Gemfile @@ -23,7 +23,7 @@ group :development, :test do gem "sentry-ruby" gem "honeybadger" gem "newrelic_rpm" - gem "ddtrace", "~> 1.8" + gem "datadog" gem "airbrake", "~> 13.0" gem "rollbar" gem "bugsnag" From 7cf2c3a5f12d41d9c70aa8078c1b0a399f2457e9 Mon Sep 17 00:00:00 2001 From: Tobias Egli Date: Wed, 1 Apr 2026 09:37:33 +0200 Subject: [PATCH 3/3] Add Ruby 3.4 and 4.0 to CI test matrix --- .github/workflows/test.yml | 2 ++ 1 file changed, 2 insertions(+) diff --git a/.github/workflows/test.yml b/.github/workflows/test.yml index 3b8f141..43ad9f3 100644 --- a/.github/workflows/test.yml +++ b/.github/workflows/test.yml @@ -28,6 +28,8 @@ jobs: - '3.1' - '3.2' - '3.3' + - '3.4' + - '4.0' steps: - uses: actions/checkout@v4