From ed407c9fe18d6ab268902d9baedf5a348f0450ce Mon Sep 17 00:00:00 2001 From: Kazuki Nishikawa Date: Tue, 15 Jul 2025 18:56:00 +0900 Subject: [PATCH 1/2] use rspec/rspec for CI --- bin/verify-sample-code | 38 ++++++++++++++++++++++---------------- 1 file changed, 22 insertions(+), 16 deletions(-) diff --git a/bin/verify-sample-code b/bin/verify-sample-code index 591d75b1..c2af422d 100755 --- a/bin/verify-sample-code +++ b/bin/verify-sample-code @@ -1,17 +1,20 @@ #!/usr/bin/env ruby # frozen_string_literal: true repos = { - "rspec/rspec-core" => { - "--exclude-pattern" => [ - "spec/rspec/core/world_spec.rb", - "spec/rspec/core/formatters/exception_presenter_spec.rb", - "spec/rspec/core/formatters/snippet_extractor_spec.rb", - "spec/rspec/core/metadata_spec.rb", - "spec/rspec/core/formatters/html_formatter_spec.rb", - "spec/rspec/core/formatters/progress_formatter_spec.rb", - "spec/rspec/core/formatters_spec.rb", - "spec/rspec/core/formatters/documentation_formatter_spec.rb", - ].join(","), + "rspec/rspec" => { + path: "rspec-core", + rspec_flags: { + "--exclude-pattern" => [ + "spec/rspec/core/world_spec.rb", + "spec/rspec/core/formatters/exception_presenter_spec.rb", + "spec/rspec/core/formatters/snippet_extractor_spec.rb", + "spec/rspec/core/metadata_spec.rb", + "spec/rspec/core/formatters/html_formatter_spec.rb", + "spec/rspec/core/formatters/progress_formatter_spec.rb", + "spec/rspec/core/formatters_spec.rb", + "spec/rspec/core/formatters/documentation_formatter_spec.rb", + ].join(","), + }, }, } @@ -54,10 +57,13 @@ def post_format_checks(repo, rspec_flags) run_rspec(repo, rspec_flags) end -repos.each do |repo, rspec_flags| +repos.each do |repo, options| + path = "#{repo}/#{options[:path]}" + rspec_flags = options[:rspec_flags] + clone_repo(repo) - setup_repo(repo) - pre_format_checks(repo, rspec_flags) - format_repo(repo) - post_format_checks(repo, rspec_flags) + setup_repo(path) + pre_format_checks(path, rspec_flags) + format_repo(path) + post_format_checks(path, rspec_flags) end From 0ad0379ce0bf438d02baf24ef43149e01554a5ac Mon Sep 17 00:00:00 2001 From: Kazuki Nishikawa Date: Tue, 15 Jul 2025 18:56:10 +0900 Subject: [PATCH 2/2] fix passing args to rake task --- bin/verify-sample-code | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/bin/verify-sample-code b/bin/verify-sample-code index c2af422d..b1c73a62 100755 --- a/bin/verify-sample-code +++ b/bin/verify-sample-code @@ -48,7 +48,7 @@ end def format_repo(repo) run_command( - "bundle exec rake rufo:run sample_code/#{repo}", + "bundle exec rake rufo:run[sample_code/#{repo}]", allowed_statuses: [0, 1, 3], ) end