Skip to content

Fix Time serialization regression from dropping MultiJson #404

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
numbata merged 4 commits into from
Jun 1, 2026
Merged

Fix Time serialization regression from dropping MultiJson #404

Show file tree
Hide file tree
Changes from 3 commits
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
9cf5d0b
Fix Time serialization regression introduced by dropping MultiJson
numbata Apr 17, 2026
09ed8be
Add CHANGELOG entry for #404
numbata Apr 17, 2026
7c577c8
Resolve merge conflicts with hotfix and drop multi_json dependency
numbata Apr 17, 2026
68854a9
Assert Time serialization against a known ISO 8601 string
numbata Jun 1, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 1 addition & 0 deletions CHANGELOG.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -7,6 +7,7 @@
#### Fixes

* Your contribution here.
* [#404](https://github.com/ruby-grape/grape-entity/pull/404): Drop `MultiJson` dependency, use `Hash#to_json` for ActiveSupport-aware serialization - [@numbata](https://github.com/numbata).

### 1.0.4 (2026-04-17)

Expand Down
1 change: 0 additions & 1 deletion grape-entity.gemspec
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -25,7 +25,6 @@ Gem::Specification.new do |s|
s.required_ruby_version = '>= 3.0'

s.add_dependency 'activesupport', '>= 3.0.0'
s.add_dependency 'multi_json', '>= 1.0'

s.files = Dir['lib/**/*.rb', 'CHANGELOG.md', 'LICENSE', 'README.md']
s.require_paths = ['lib']
Expand Down
4 changes: 1 addition & 3 deletions lib/grape_entity/entity.rb
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,7 +1,5 @@
# frozen_string_literal: true

require 'multi_json'

module Grape
# An Entity is a lightweight structure that allows you to easily
# represent data from your application in a consistent and abstracted
Comment thread
numbata marked this conversation as resolved.
Expand Down Expand Up @@ -594,7 +592,7 @@ def is_defined_in_entity?(attribute)

def to_json(options = {})
options = options.to_h if options&.respond_to?(:to_h)
MultiJson.dump(serializable_hash(options))
serializable_hash(options).to_json
end

def to_xml(options = {})
Expand Down
Loading