Commit 0942165
committed
Address review findings: scope-aware variant keys, robust desc kwargs
VariantCollectionCoercer recovery (route.rb)
- Build the variant-type map keyed by the fully-qualified param name
(e.g. "group[inner]") via the validator's @scope.full_name(attr), so
nested-param multi-types are restored instead of being looked up under
the wrong key, and same-named outer params at a different scope are not
clobbered.
- Use the public validator.attrs reader, and normalise the recovered
@types to an Array so an order-defined coercer Set cannot leak in.
- Cover the inheritance shape of stackable[:validations] with .flatten.
desc keyword-args (doc_methods.rb)
- Coerce api_documentation / specific_api_documentation keys to symbols
via transform_keys before splatting, so string-keyed Hashes (YAML/JSON
configs) no longer raise TypeError under `**`.
- Accept :description as an alias for :desc. Without this, a user-supplied
:description was forwarded into Grape's desc and immediately overwritten
with nil because the positional description arg was missing.
Tests
- Add a regression spec asserting `type: [Integer, Float]` produces
"integer" (the only assertion that proves the recovery actually wires
the real types through; previously [String, Integer] also "worked" via
the broken fallback because String happens to be first).
- Cover the nested-namespace case (`group { requires :inner, type: [...] }`)
to lock in the scope-aware key.
CHANGELOG
- Document the >= 2.1 Grape floor bump and the `type: 'Object'` migration
pattern under a Breaking changes section, and split the multi-type
recovery and desc-kwargs robustness fixes into separate entries.1 parent 54465f4 commit 0942165
4 files changed
Lines changed: 51 additions & 9 deletions
File tree
- lib/grape-swagger
- request_param_parsers
- spec/swagger_v2
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
| |||
4 | 4 | | |
5 | 5 | | |
6 | 6 | | |
| 7 | + | |
| 8 | + | |
| 9 | + | |
| 10 | + | |
| 11 | + | |
7 | 12 | | |
8 | 13 | | |
9 | 14 | | |
| 15 | + | |
| 16 | + | |
10 | 17 | | |
11 | 18 | | |
12 | 19 | | |
| |||
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
| |||
86 | 86 | | |
87 | 87 | | |
88 | 88 | | |
89 | | - | |
90 | | - | |
| 89 | + | |
| 90 | + | |
91 | 91 | | |
92 | 92 | | |
93 | 93 | | |
94 | 94 | | |
95 | 95 | | |
96 | | - | |
| 96 | + | |
97 | 97 | | |
98 | 98 | | |
99 | 99 | | |
| |||
105 | 105 | | |
106 | 106 | | |
107 | 107 | | |
108 | | - | |
| 108 | + | |
109 | 109 | | |
110 | 110 | | |
111 | 111 | | |
| |||
136 | 136 | | |
137 | 137 | | |
138 | 138 | | |
| 139 | + | |
| 140 | + | |
| 141 | + | |
| 142 | + | |
139 | 143 | | |
140 | 144 | | |
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
| |||
52 | 52 | | |
53 | 53 | | |
54 | 54 | | |
55 | | - | |
| 55 | + | |
| 56 | + | |
56 | 57 | | |
57 | 58 | | |
58 | 59 | | |
59 | 60 | | |
60 | 61 | | |
61 | 62 | | |
62 | | - | |
| 63 | + | |
63 | 64 | | |
64 | 65 | | |
65 | 66 | | |
66 | 67 | | |
67 | 68 | | |
68 | | - | |
69 | | - | |
70 | | - | |
| 69 | + | |
| 70 | + | |
| 71 | + | |
| 72 | + | |
71 | 73 | | |
72 | 74 | | |
73 | 75 | | |
| |||
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
| |||
50 | 50 | | |
51 | 51 | | |
52 | 52 | | |
| 53 | + | |
| 54 | + | |
| 55 | + | |
| 56 | + | |
| 57 | + | |
| 58 | + | |
| 59 | + | |
| 60 | + | |
| 61 | + | |
| 62 | + | |
| 63 | + | |
| 64 | + | |
| 65 | + | |
| 66 | + | |
| 67 | + | |
| 68 | + | |
| 69 | + | |
| 70 | + | |
| 71 | + | |
| 72 | + | |
| 73 | + | |
| 74 | + | |
| 75 | + | |
| 76 | + | |
| 77 | + | |
| 78 | + | |
| 79 | + | |
| 80 | + | |
| 81 | + | |
53 | 82 | | |
54 | 83 | | |
55 | 84 | | |
| |||
0 commit comments