Commit 2457d42
committed
Bump to 2.2.0; document breaking changes and tighten review nits
Per maintainer feedback on PR #978, this release carries breaking
changes (Grape floor bump, `type: 'Object'` migration, custom-type
`parse` requirement) and therefore lands as 2.2.0, with a matching
UPGRADING entry and README compatibility-matrix row.
Docs
- README: add a `>= 2.2.0` compatibility row and cap the prior row at
`< 2.2.0`. Document the new `:description` alias / string-keyed
`api_documentation` affordance and the `:desc` precedence rule.
- UPGRADING: new "Upgrading to >= 2.2.0" section covering all three
user-facing breaking changes (Grape floor, `type: 'Object'`, custom
types needing `.parse`).
- CHANGELOG: split bullets into Breaking changes / Features / Fixes
with accurate wording. Drop the misleading "matching the pre-keyword
-args behaviour" framing — `:description` and string keys are new
affordances. Add the custom-type `parse` requirement. Note that the
variant-type recovery is a no-op on Grape < 3.3.
Code
- `pop_desc` is now private; it was an internal helper to `setup` but
was leaking onto every `Grape::API` that mixed in `DocMethods`.
- `route.rb`: `flatten(1)` instead of unbounded `.flatten`, and skip
the merge when the recovered coercer `@types` is empty so we don't
overwrite the legacy serialisation with `[]`.
Tests
- Add regression coverage for the parts of `pop_desc` that the v2 fix
was actually for: explicit `desc: nil` must not fall through to
`:description`, and `specific_api_documentation: { description: ... }`
goes through the second `pop_desc` call site too.
Public-API audit: `@converter` / `@types` (on VariantCollectionCoercer)
and `@scope` (on Validators::Base) have no public reader on the supported
Grape range (`scope` is private on HEAD and absent on 3.2.1), so the
`instance_variable_get` reaches remain — there is no stable public
alternative across the matrix.1 parent 64ebd4c commit 2457d42
7 files changed
Lines changed: 70 additions & 15 deletions
File tree
- lib/grape-swagger
- request_param_parsers
- spec/swagger_v2
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
| |||
1 | | - | |
| 1 | + | |
2 | 2 | | |
3 | | - | |
| 3 | + | |
4 | 4 | | |
5 | | - | |
| 5 | + | |
| 6 | + | |
| 7 | + | |
6 | 8 | | |
7 | | - | |
| 9 | + | |
8 | 10 | | |
9 | | - | |
10 | | - | |
| 11 | + | |
11 | 12 | | |
12 | 13 | | |
13 | 14 | | |
14 | | - | |
15 | | - | |
16 | | - | |
| 15 | + | |
| 16 | + | |
17 | 17 | | |
18 | 18 | | |
19 | 19 | | |
| |||
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
| |||
125 | 125 | | |
126 | 126 | | |
127 | 127 | | |
128 | | - | |
| 128 | + | |
| 129 | + | |
129 | 130 | | |
130 | 131 | | |
131 | 132 | | |
| |||
498 | 499 | | |
499 | 500 | | |
500 | 501 | | |
| 502 | + | |
| 503 | + | |
501 | 504 | | |
502 | 505 | | |
503 | 506 | | |
| |||
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
| |||
1 | 1 | | |
2 | 2 | | |
| 3 | + | |
| 4 | + | |
| 5 | + | |
| 6 | + | |
| 7 | + | |
| 8 | + | |
| 9 | + | |
| 10 | + | |
| 11 | + | |
| 12 | + | |
| 13 | + | |
| 14 | + | |
| 15 | + | |
| 16 | + | |
| 17 | + | |
| 18 | + | |
| 19 | + | |
| 20 | + | |
| 21 | + | |
| 22 | + | |
| 23 | + | |
3 | 24 | | |
4 | 25 | | |
5 | 26 | | |
| |||
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
| |||
137 | 137 | | |
138 | 138 | | |
139 | 139 | | |
| 140 | + | |
| 141 | + | |
| 142 | + | |
| 143 | + | |
140 | 144 | | |
141 | | - | |
142 | | - | |
143 | 145 | | |
144 | 146 | | |
145 | 147 | | |
| |||
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
| |||
64 | 64 | | |
65 | 65 | | |
66 | 66 | | |
67 | | - | |
| 67 | + | |
| 68 | + | |
| 69 | + | |
| 70 | + | |
68 | 71 | | |
69 | 72 | | |
70 | 73 | | |
| |||
73 | 76 | | |
74 | 77 | | |
75 | 78 | | |
| 79 | + | |
| 80 | + | |
76 | 81 | | |
77 | 82 | | |
78 | 83 | | |
| |||
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
| |||
1 | 1 | | |
2 | 2 | | |
3 | 3 | | |
4 | | - | |
| 4 | + | |
5 | 5 | | |
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
| |||
56 | 56 | | |
57 | 57 | | |
58 | 58 | | |
59 | | - | |
| 59 | + | |
| 60 | + | |
| 61 | + | |
| 62 | + | |
| 63 | + | |
| 64 | + | |
| 65 | + | |
| 66 | + | |
| 67 | + | |
| 68 | + | |
| 69 | + | |
| 70 | + | |
| 71 | + | |
| 72 | + | |
| 73 | + | |
| 74 | + | |
| 75 | + | |
| 76 | + | |
| 77 | + | |
| 78 | + | |
| 79 | + | |
| 80 | + | |
| 81 | + | |
| 82 | + | |
| 83 | + | |
60 | 84 | | |
61 | 85 | | |
62 | 86 | | |
0 commit comments