Commit 5b62850
Remove the dead format keyword from Grape::Router::Pattern
`Pattern#initialize` took a `format:` keyword and, in `extract_capture`,
constrained the mustermann `:format` capture with it. But nothing ever
passed a non-nil value: the endpoint stopped passing `format:` when the
vestigial `Grape::Endpoint::Options` `format` member was removed (#2779),
and grape-swagger's helper passes `format: nil`. It was also redundant —
a route's `:format` capture comes from the path suffix built by
`Grape::Path` (`(.json)` for a specific format, `(.:format)` otherwise),
not from the pattern.
Drop the keyword and the dead capture branch. `DEFAULT_CAPTURES` still
lists `format` (the path-derived capture) and `map_str` still serves
`version`, so matching is unchanged. `Grape::Router::Pattern.new(...,
format: …)` now raises `unknown keyword: :format`; corrected the
UPGRADING note that previously described it as an optional keyword.
Co-Authored-By: Claude Opus 4.8 (1M context) <noreply@anthropic.com>1 parent 9ece4d9 commit 5b62850
4 files changed
Lines changed: 5 additions & 6 deletions
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
| |||
9 | 9 | | |
10 | 10 | | |
11 | 11 | | |
| 12 | + | |
12 | 13 | | |
13 | 14 | | |
14 | 15 | | |
| |||
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
| |||
58 | 58 | | |
59 | 59 | | |
60 | 60 | | |
61 | | - | |
| 61 | + | |
62 | 62 | | |
63 | 63 | | |
64 | 64 | | |
| |||
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
| |||
13 | 13 | | |
14 | 14 | | |
15 | 15 | | |
16 | | - | |
| 16 | + | |
17 | 17 | | |
18 | 18 | | |
19 | | - | |
| 19 | + | |
20 | 20 | | |
21 | 21 | | |
22 | 22 | | |
| |||
28 | 28 | | |
29 | 29 | | |
30 | 30 | | |
31 | | - | |
| 31 | + | |
32 | 32 | | |
33 | | - | |
34 | 33 | | |
35 | 34 | | |
36 | 35 | | |
| |||
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
| |||
10 | 10 | | |
11 | 11 | | |
12 | 12 | | |
13 | | - | |
14 | 13 | | |
15 | 14 | | |
16 | 15 | | |
| |||
0 commit comments