Commit 6025bf4
Detect the MultiXML constant to avoid the multi_xml deprecation
multi_xml 0.9.0 deprecated the `MultiXml` constant in favor of `MultiXML`
(removed in v1.0); the legacy constant warns on access/use. Grape detected
the backend via `::MultiXml` and called `Grape::Xml.parse`, so users on
multi_xml >= 0.9 would hit the deprecation.
Detect `::MultiXML` first, falling back to the legacy `::MultiXml` constant
and then `ActiveSupport::XmlMini`. Unlike multi_json, no facade is needed:
`parse` is canonical (not renamed) and Grape only calls `parse`, so a direct
alias suffices on every backend.
Cover both multi_xml lines in CI: pin gemfiles/multi_xml.gemfile to >= 0.9
and add gemfiles/multi_xml_0_8.gemfile (< 0.9), each running the
spec/integration/multi_xml suite. The integration spec now drives a real
Grape API that parses an XML request body through Grape::Xml.parse.
Co-Authored-By: Claude Opus 4.8 (1M context) <noreply@anthropic.com>1 parent 1477dc5 commit 6025bf4
6 files changed
Lines changed: 36 additions & 4 deletions
File tree
- .github/workflows
- gemfiles
- lib/grape
- spec/integration/multi_xml
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
| |||
53 | 53 | | |
54 | 54 | | |
55 | 55 | | |
| 56 | + | |
| 57 | + | |
| 58 | + | |
56 | 59 | | |
57 | 60 | | |
58 | 61 | | |
| |||
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
| |||
75 | 75 | | |
76 | 76 | | |
77 | 77 | | |
| 78 | + | |
78 | 79 | | |
79 | 80 | | |
80 | 81 | | |
| |||
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
| |||
1 | 1 | | |
2 | 2 | | |
3 | | - | |
| 3 | + | |
4 | 4 | | |
5 | 5 | | |
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
| |||
| 1 | + | |
| 2 | + | |
| 3 | + | |
| 4 | + | |
| 5 | + | |
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
| |||
1 | 1 | | |
2 | 2 | | |
3 | 3 | | |
4 | | - | |
| 4 | + | |
| 5 | + | |
| 6 | + | |
| 7 | + | |
| 8 | + | |
| 9 | + | |
| 10 | + | |
| 11 | + | |
5 | 12 | | |
6 | 13 | | |
7 | 14 | | |
| |||
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
| |||
1 | 1 | | |
2 | 2 | | |
3 | 3 | | |
4 | | - | |
| 4 | + | |
| 5 | + | |
| 6 | + | |
| 7 | + | |
| 8 | + | |
| 9 | + | |
| 10 | + | |
| 11 | + | |
| 12 | + | |
| 13 | + | |
| 14 | + | |
5 | 15 | | |
6 | | - | |
| 16 | + | |
| 17 | + | |
| 18 | + | |
| 19 | + | |
| 20 | + | |
| 21 | + | |
| 22 | + | |
7 | 23 | | |
0 commit comments