Merge pull request rubycentral#884 from amatsuda/fix_rating

Fix a bug that clicking a star with pointer cursor sends score: 1

Author: amatsuda

app/assets/stylesheets/modules/ratings.css

@@ -43,6 +43,7 @@
     text-align: center;
     direction: rtl;
     font-size: 18px;
+    cursor: pointer;
 
     * {
       position: absolute;
@@ -58,14 +59,21 @@
       }
     }
 
+    label {
+      cursor: pointer;
+    }
+
     input {
       z-index: 5;
       cursor: pointer;
       opacity: 0;
+      width: 18px;
+      height: 18px;
     }
 
     &.ratings-closed {
       color: var(--gray);
+      cursor: default;
 
       input {
         pointer-events: none;

app/views/shared/proposals/_rating_form.html.haml

@@ -11,23 +11,21 @@
         .rating-form-wrapper
           %ul.star-rating
             - (1..5).each do |score|
-              %li.star-wrapper{class: disabled ? "ratings-closed" : nil}
-                = f.label :score, data: {action: 'mouseenter->rating#preview mouseleave->rating#showRating'} do
-                  %span.star
-                    %i.bi.bi-star
-                    %i.bi.bi-star-fill
-                  = f.check_box :score, {class: 'star-rating-select', disabled: disabled}, score, nil
+              %li.star-wrapper{class: disabled ? "ratings-closed" : nil, data: {action: 'mouseenter->rating#preview mouseleave->rating#showRating'}}
+                %span.star
+                  %i.bi.bi-star
+                  %i.bi.bi-star-fill
+                = f.check_box :score, {class: 'star-rating-select', disabled: disabled}, score, nil
             - if show_ratings_toggle?(proposal, rating)
               %li.abstain-wrapper
                 = link_to "#", class: 'abstain', data: {action: 'click->rating#toggleCommentsAndRatings'} do
                   %i.bi.bi-chat-dots
                   %i.bi.bi-chat-dots-fill.hidden
             - if show_destroy_rating?(proposal, rating)
-              %li.trash-wrapper
-                = f.label :score, data: {action: 'mouseenter->rating#previewDelete mouseleave->rating#cancelPreviewDelete'} do
-                  %span.trash
-                    %i.bi.bi-trash
-                  = f.check_box :score, { class: "star-rating-select delete" }, "", nil
+              %li.trash-wrapper{data: {action: 'mouseenter->rating#previewDelete mouseleave->rating#cancelPreviewDelete'}}
+                %span.trash
+                  %i.bi.bi-trash
+                = f.check_box :score, { class: "star-rating-select delete" }, "", nil
   #show-ratings{ class: !show_ratings?(proposal, rating) ? "hidden" : nil }
     .col-lg-7
       - if proposal.ratings.any?