Support revocation with URL-encoded parameters#656
Merged
Conversation
Contributor
Author
|
@pboling can you please take a look? pipeline is failing but doesn't seem to be related to this PR? |
Member
|
I'll fix that! It's because I released the appraisal2 gem and deleted the old fork branch this project had been relying on. More here: https://dev.to/galtzo/ann-appraisal2-a-hard-fork-44dh |
Member
|
CI is fixed in main! Please rebase @srook |
srook
force-pushed
the
urlencoded-params-token-revocation
branch
from
97c009a to
b9986a1
Compare
Pull Request Test Coverage Report for Build 16771995951Details
💛 - Coveralls |
srook
force-pushed
the
urlencoded-params-token-revocation
branch
from
b9986a1 to
dddc568
Compare
Contributor
Author
|
thanks, but there still seems to be some issue with codecov, @pboling ? |
Member
|
I have filed several bugs with them. Their system is broken in a few ways, and we don't know yet how to get it working (again) in this repo. For now we will ignore that. |
pboling
approved these changes
Aug 6, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #655