Use MultiXML constant to fix deprecation warning from multi_xml 0.9+#733
Merged
pboling merged 1 commit intoJun 12, 2026
Merged
Conversation
robzolkos
force-pushed
the
fix-multi-xml-deprecation-warning
branch
3 times, most recently
from
132ae84 to
e2cf592
Compare
Falls back to MultiXml for older versions so no minimum version bump is required.
robzolkos
force-pushed
the
fix-multi-xml-deprecation-warning
branch
from
e2cf592 to
5e776bb
Compare
Member
|
Nice! We'll be bumping dependency versions in a major release, along with the bumped min ruby! This is perfect for a patch release. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
multi_xml 0.9.0 renamed the top-level constant from `MultiXml` to `MultiXML` and made the old name a deprecated shim that emits a warning on every method call:
```
The MultiXml constant is deprecated and will be removed in v1.0. Use MultiXML instead.
```
This uses `defined?(MultiXML)` to prefer the new constant when available (multi_xml >= 0.9), falling back to `MultiXml` on older versions. No minimum version bump required — the fix is fully backward compatible.