Skip to content

Commit e41431b

Browse files
committed
🐛 Fix load_extensions.run for Ruby <= 2.6
1 parent 5b4b225 commit e41431b

26 files changed

Lines changed: 63 additions & 50 deletions

.github/workflows/ancient.yml

Lines changed: 16 additions & 16 deletions
Original file line numberDiff line numberDiff line change
@@ -37,26 +37,26 @@ jobs:
3737
# Ruby 2.3
3838
- ruby: "ruby-2.3"
3939
appraisal: "ruby-2-3"
40-
exec_cmd: "rspec spec/snaky_hash/serializer_spec.rb:13"
40+
exec_cmd: "rake test"
4141
gemfile: "Appraisal.root"
4242
rubygems: "3.3.27"
4343
bundler: "2.3.27"
4444

45-
# # Ruby 2.4
46-
# - ruby: "ruby-2.4"
47-
# appraisal: "ruby-2-4"
48-
# exec_cmd: "rake test"
49-
# gemfile: "Appraisal.root"
50-
# rubygems: "3.3.27"
51-
# bundler: "2.3.27"
52-
#
53-
# # Ruby 2.5
54-
# - ruby: "ruby-2.5"
55-
# appraisal: "ruby-2-5"
56-
# exec_cmd: "rake test"
57-
# gemfile: "Appraisal.root"
58-
# rubygems: "3.3.27"
59-
# bundler: "2.3.27"
45+
# Ruby 2.4
46+
- ruby: "ruby-2.4"
47+
appraisal: "ruby-2-4"
48+
exec_cmd: "rake test"
49+
gemfile: "Appraisal.root"
50+
rubygems: "3.3.27"
51+
bundler: "2.3.27"
52+
53+
# Ruby 2.5
54+
- ruby: "ruby-2.5"
55+
appraisal: "ruby-2-5"
56+
exec_cmd: "rake test"
57+
gemfile: "Appraisal.root"
58+
rubygems: "3.3.27"
59+
bundler: "2.3.27"
6060

6161
steps:
6262
- name: Checkout

CHANGELOG.md

Lines changed: 3 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -14,8 +14,8 @@ and this project adheres to [Semantic Versioning v2](https://semver.org/spec/v2.
1414

1515
## [2.0.3] - 2025-05-23
1616
- TAG: [v2.0.3][2.0.3t]
17-
- COVERAGE: 100.00% -- 130/130 lines in 7 files
18-
- BRANCH COVERAGE: 100.00% -- 37/37 branches in 7 files
17+
- COVERAGE: 100.00% -- 132/132 lines in 7 files
18+
- BRANCH COVERAGE: 100.00% -- 38/38 branches in 7 files
1919
- 100.00% documented
2020
### Added
2121
- `#dump` instance method injected by `extend SnakyHash::Serializer` (@pboling)
@@ -24,7 +24,7 @@ and this project adheres to [Semantic Versioning v2](https://semver.org/spec/v2.
2424
- `load_value_extensions` - alternate name for `load_extensions` (@pboling)
2525
- Clarifying documentation (@pboling)
2626
### Fixed
27-
- Serializer extensions dump and load empty values properly (@pboling)
27+
- [gh4](https://github.com/oauth-xx/snaky_hash/pull/4) - Serializer extensions dump and load empty values properly (@pboling)
2828
- Fixed `dump_extensions`, `load_extensions`, `load_hash_extensions`
2929
- Intended usage is primarily JSON, and oauth2 gem
3030
- OAuth2 spec can have legitimately empty values (e.g. scopes could be empty)

README.md

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -590,7 +590,7 @@ or one of the others at the head of this README.
590590
[📌gitmoji]:https://gitmoji.dev
591591
[📌gitmoji-img]:https://img.shields.io/badge/gitmoji_commits-%20😜%20😍-34495e.svg?style=flat-square
592592
[🧮kloc]: https://www.youtube.com/watch?v=dQw4w9WgXcQ
593-
[🧮kloc-img]: https://img.shields.io/badge/KLOC-0.130-FFDD67.svg?style=for-the-badge&logo=YouTube&logoColor=blue
593+
[🧮kloc-img]: https://img.shields.io/badge/KLOC-0.132-FFDD67.svg?style=for-the-badge&logo=YouTube&logoColor=blue
594594
[🔐security]: SECURITY.md
595595
[🔐security-img]: https://img.shields.io/badge/security-policy-259D6C.svg?style=flat
596596
[📄copyright-notice-explainer]: https://opensource.stackexchange.com/questions/5778/why-do-licenses-such-as-the-mit-license-specify-a-single-year

REEK

Lines changed: 4 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -2,12 +2,13 @@ spec/snaky_hash/snake_spec.rb -- 1 warning:
22
[4]:IrresponsibleModule: TheSnakedHash has no descriptive comment [https://github.com/troessner/reek/blob/v6.5.0/docs/Irresponsible-Module.md]
33
lib/snaky_hash/extensions.rb -- 1 warning:
44
[11]:InstanceVariableAssumption: SnakyHash::Extensions assumes too much for instance variable '@extensions' [https://github.com/troessner/reek/blob/v6.5.0/docs/Instance-Variable-Assumption.md]
5-
lib/snaky_hash/serializer.rb -- 6 warnings:
5+
lib/snaky_hash/serializer.rb -- 7 warnings:
66
[132]:NilCheck: SnakyHash::Serializer#blank? performs a nil-check [https://github.com/troessner/reek/blob/v6.5.0/docs/Nil-Check.md]
7+
[180]:TooManyStatements: SnakyHash::Serializer#load_hash has approx 6 statements [https://github.com/troessner/reek/blob/v6.5.0/docs/Too-Many-Statements.md]
78
[99]:TooManyStatements: SnakyHash::Serializer::BackportedInstanceMethods#transform_values has approx 7 statements [https://github.com/troessner/reek/blob/v6.5.0/docs/Too-Many-Statements.md]
89
[58]:TooManyStatements: SnakyHash::Serializer::Modulizer#to_extended_mod has approx 13 statements [https://github.com/troessner/reek/blob/v6.5.0/docs/Too-Many-Statements.md]
910
[170]:UncommunicativeVariableName: SnakyHash::Serializer#dump_value has the variable name 'v' [https://github.com/troessner/reek/blob/v6.5.0/docs/Uncommunicative-Variable-Name.md]
10-
[203]:UncommunicativeVariableName: SnakyHash::Serializer#load_value has the variable name 'v' [https://github.com/troessner/reek/blob/v6.5.0/docs/Uncommunicative-Variable-Name.md]
11+
[214]:UncommunicativeVariableName: SnakyHash::Serializer#load_value has the variable name 'v' [https://github.com/troessner/reek/blob/v6.5.0/docs/Uncommunicative-Variable-Name.md]
1112
[131]:UtilityFunction: SnakyHash::Serializer#blank? doesn't depend on instance state (maybe move it to another class?) [https://github.com/troessner/reek/blob/v6.5.0/docs/Utility-Function.md]
1213
lib/snaky_hash/snake.rb -- 11 warnings:
1314
[30]:BooleanParameter: SnakyHash::Snake#initialize has boolean parameter 'serializer' [https://github.com/troessner/reek/blob/v6.5.0/docs/Boolean-Parameter.md]
@@ -23,4 +24,4 @@ lib/snaky_hash/snake.rb -- 11 warnings:
2324
[93]:UncommunicativeVariableName: SnakyHash::Snake::SnakyModulizer#to_mod has the variable name 'e' [https://github.com/troessner/reek/blob/v6.5.0/docs/Uncommunicative-Variable-Name.md]
2425
.yard_gfm_support.rb -- 1 warning:
2526
[9, 9]:FeatureEnvy: KramdownGfmDocument#initialize refers to 'options' more than self (maybe move it to another class?) [https://github.com/troessner/reek/blob/v6.5.0/docs/Feature-Envy.md]
26-
20 total warnings
27+
21 total warnings

doc/SnakyHash.html

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -147,7 +147,7 @@ <h5 class="example_title"><div class='inline'><p>Usage with symbol keys and seri
147147
</div>
148148

149149
<div id="footer">
150-
Generated on Fri May 23 07:54:25 2025 by
150+
Generated on Fri May 23 09:04:15 2025 by
151151
<a href="https://yardoc.org" title="Yay! A Ruby Documentation Tool" target="_parent">yard</a>
152152
0.9.37 (ruby-3.4.3).
153153
</div>

doc/SnakyHash/Error.html

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -124,7 +124,7 @@ <h2>Overview</h2><div class="docstring">
124124
</div>
125125

126126
<div id="footer">
127-
Generated on Fri May 23 07:54:25 2025 by
127+
Generated on Fri May 23 09:04:15 2025 by
128128
<a href="https://yardoc.org" title="Yay! A Ruby Documentation Tool" target="_parent">yard</a>
129129
0.9.37 (ruby-3.4.3).
130130
</div>

doc/SnakyHash/Extensions.html

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -645,7 +645,7 @@ <h3 class="signature " id="run-instance_method">
645645
</div>
646646

647647
<div id="footer">
648-
Generated on Fri May 23 07:54:25 2025 by
648+
Generated on Fri May 23 09:04:15 2025 by
649649
<a href="https://yardoc.org" title="Yay! A Ruby Documentation Tool" target="_parent">yard</a>
650650
0.9.37 (ruby-3.4.3).
651651
</div>

doc/SnakyHash/Serializer.html

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -462,7 +462,7 @@ <h3 class="signature " id="load-instance_method">
462462
</div>
463463

464464
<div id="footer">
465-
Generated on Fri May 23 07:54:25 2025 by
465+
Generated on Fri May 23 09:04:15 2025 by
466466
<a href="https://yardoc.org" title="Yay! A Ruby Documentation Tool" target="_parent">yard</a>
467467
0.9.37 (ruby-3.4.3).
468468
</div>

doc/SnakyHash/Serializer/BackportedInstanceMethods.html

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -254,7 +254,7 @@ <h3 class="signature first" id="transform_values-instance_method">
254254
</div>
255255

256256
<div id="footer">
257-
Generated on Fri May 23 07:54:25 2025 by
257+
Generated on Fri May 23 09:04:15 2025 by
258258
<a href="https://yardoc.org" title="Yay! A Ruby Documentation Tool" target="_parent">yard</a>
259259
0.9.37 (ruby-3.4.3).
260260
</div>

doc/SnakyHash/Serializer/ConvenienceInstanceMethods.html

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -214,7 +214,7 @@ <h3 class="signature first" id="dump-instance_method">
214214
</div>
215215

216216
<div id="footer">
217-
Generated on Fri May 23 07:54:25 2025 by
217+
Generated on Fri May 23 09:04:15 2025 by
218218
<a href="https://yardoc.org" title="Yay! A Ruby Documentation Tool" target="_parent">yard</a>
219219
0.9.37 (ruby-3.4.3).
220220
</div>

0 commit comments

Comments
 (0)