Allow opting out of content-based FIFO deduplication for raw sends#1038
Draft
mensfeld wants to merge 1 commit into
Draft
Allow opting out of content-based FIFO deduplication for raw sends#1038mensfeld wants to merge 1 commit into
mensfeld wants to merge 1 commit into
Conversation
Queue#add_fifo_attributes! always set message_deduplication_id to a SHA256 of the body when none was provided, so two raw sends of an identical body within SQS's 5-minute window (Worker.perform_async, Queue#send_message/#send_messages) were silently deduplicated - the second dropped. ActiveJob got an opt-out in #1017 (active_job_fifo_message_deduplication) but the raw path had none. Add the symmetric Shoryuken.fifo_message_deduplication flag (default true, so behaviour is unchanged). When set false, Shoryuken no longer auto-generates the dedup id; callers provide message_deduplication_id themselves or enable ContentBasedDeduplication on the queue.
|
Important Review skippedDraft detected. Please check the settings in the CodeRabbit UI or the ⚙️ Run configurationConfiguration used: defaults Review profile: CHILL Plan: Pro Run ID: You can disable this status message by setting the Use the checkbox below for a quick retry:
✨ Finishing Touches🧪 Generate unit tests (beta)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Queue#add_fifo_attributes! always set message_deduplication_id to a SHA256 of the body when none was provided, so two raw sends of an identical body within SQS's 5-minute window (Worker.perform_async, Queue#send_message/#send_messages) were silently deduplicated - the second dropped. ActiveJob got an opt-out in #1017
(active_job_fifo_message_deduplication) but the raw path had none.
Add the symmetric Shoryuken.fifo_message_deduplication flag (default true, so behaviour is unchanged). When set false, Shoryuken no longer auto-generates the dedup id; callers provide message_deduplication_id themselves or enable ContentBasedDeduplication on the queue.