[Bug Fix] Toast review polish: swap promise icon, drop dead code, more tests

Issues found and fixed during implementation review:

- _mutate (promise transitions) now swaps the icon SVG to match the
  resolved variant, and updates aria role for error case. Previously
  loading -> success kept the spinner.
- Drop unused dataset bracket-key assignment in _spawn (only the
  setAttribute path was effective).
- _dismissById iterates the tracked _items list rather than raw OL
  children (defensive against non-toast nodes).
- Drop unused POSITIONS constant from ToastRegion.
- Add Minitest coverage for ToastAction label/data-action,
  ToastCancel label, ToastClose dismiss action + sr-only,
  ToastIcon per-variant SVG content, ToastTitle/Description slots.

181 runs, 787 assertions, 0 failures.

Author: djalmaaraujo

docs/app/javascript/controllers/ruby_ui/toaster_controller.js

@@ -82,7 +82,6 @@ export default class extends Controller {
     node.id = detail.id || `toast-${this._uuid()}`
     if (detail.duration != null) {
       const dur = detail.duration === Infinity ? 0 : detail.duration
-      node.dataset["rubyUi--ToastDurationValue"] = String(dur)
       node.setAttribute("data-ruby-ui--toast-duration-value", String(dur))
     }
     if (detail.dismissible === false) {
@@ -128,8 +127,8 @@ export default class extends Controller {
 
   _dismissById(id) {
     if (!id) {
-      Array.from(this._listEl.children).forEach((c) =>
-        c.dispatchEvent(new CustomEvent("ruby-ui:toast:force-dismiss", { bubbles: true }))
+      this._items.slice().forEach((el) =>
+        el.dispatchEvent(new CustomEvent("ruby-ui:toast:force-dismiss", { bubbles: true }))
       )
       return
     }
@@ -271,13 +270,24 @@ export default class extends Controller {
     const el = this._listEl.querySelector(`#${CSS.escape(id)}`)
     if (!el) return
     el.dataset.variant = variant
+    el.setAttribute("role", variant === "error" ? "alert" : "status")
+    this._swapIcon(el, variant)
     const t = el.querySelector('[data-slot="title"]')
     if (t && text) t.textContent = text
     const dur = String(this.durationValue)
     el.setAttribute("data-ruby-ui--toast-duration-value", dur)
     el.dispatchEvent(new CustomEvent("ruby-ui:toast:restart", { bubbles: true }))
   }
 
+  _swapIcon(el, variant) {
+    const iconHost = el.querySelector('[data-slot="icon"]')
+    if (!iconHost) return
+    const tpl = this._skeletonFor(variant)
+    if (!tpl) return
+    const sourceIcon = tpl.content.firstElementChild?.querySelector('[data-slot="icon"]')
+    iconHost.innerHTML = sourceIcon ? sourceIcon.innerHTML : ""
+  }
+
   _uuid() {
     if (typeof crypto !== "undefined" && crypto.randomUUID) return crypto.randomUUID()
     return Math.random().toString(36).slice(2) + Date.now().toString(36)

gem/lib/ruby_ui/toast/toast_region.rb

@@ -3,7 +3,6 @@
 module RubyUI
   class ToastRegion < Base
     SKELETON_VARIANTS = %i[default success error warning info loading].freeze
-    POSITIONS = %i[top_left top_center top_right bottom_left bottom_center bottom_right].freeze
 
     def initialize(
       position: :bottom_right,

gem/lib/ruby_ui/toast/toaster_controller.js

@@ -82,7 +82,6 @@ export default class extends Controller {
     node.id = detail.id || `toast-${this._uuid()}`
     if (detail.duration != null) {
       const dur = detail.duration === Infinity ? 0 : detail.duration
-      node.dataset["rubyUi--ToastDurationValue"] = String(dur)
       node.setAttribute("data-ruby-ui--toast-duration-value", String(dur))
     }
     if (detail.dismissible === false) {
@@ -128,8 +127,8 @@ export default class extends Controller {
 
   _dismissById(id) {
     if (!id) {
-      Array.from(this._listEl.children).forEach((c) =>
-        c.dispatchEvent(new CustomEvent("ruby-ui:toast:force-dismiss", { bubbles: true }))
+      this._items.slice().forEach((el) =>
+        el.dispatchEvent(new CustomEvent("ruby-ui:toast:force-dismiss", { bubbles: true }))
       )
       return
     }
@@ -271,13 +270,24 @@ export default class extends Controller {
     const el = this._listEl.querySelector(`#${CSS.escape(id)}`)
     if (!el) return
     el.dataset.variant = variant
+    el.setAttribute("role", variant === "error" ? "alert" : "status")
+    this._swapIcon(el, variant)
     const t = el.querySelector('[data-slot="title"]')
     if (t && text) t.textContent = text
     const dur = String(this.durationValue)
     el.setAttribute("data-ruby-ui--toast-duration-value", dur)
     el.dispatchEvent(new CustomEvent("ruby-ui:toast:restart", { bubbles: true }))
   }
 
+  _swapIcon(el, variant) {
+    const iconHost = el.querySelector('[data-slot="icon"]')
+    if (!iconHost) return
+    const tpl = this._skeletonFor(variant)
+    if (!tpl) return
+    const sourceIcon = tpl.content.firstElementChild?.querySelector('[data-slot="icon"]')
+    iconHost.innerHTML = sourceIcon ? sourceIcon.innerHTML : ""
+  }
+
   _uuid() {
     if (typeof crypto !== "undefined" && crypto.randomUUID) return crypto.randomUUID()
     return Math.random().toString(36).slice(2) + Date.now().toString(36)

gem/test/ruby_ui/toast_test.rb

@@ -27,4 +27,52 @@ def test_flash_variant_helper
     assert_equal :warning, RubyUI::Toast.flash_variant("alert")
     assert_equal :default, RubyUI::Toast.flash_variant(:unknown)
   end
+
+  def test_action_renders_label_and_action_attr
+    out = phlex { RubyUI.ToastAction(label: "Undo", on: "click->thing#undo") }
+    assert_match(/Undo/, out)
+    assert_match(/data-slot="action"/, out)
+    assert_match(/data-action="click->thing#undo"/, out)
+  end
+
+  def test_cancel_renders_label_and_dismiss_action
+    out = phlex { RubyUI.ToastCancel(label: "Dismiss") }
+    assert_match(/Dismiss/, out)
+    assert_match(/data-slot="cancel"/, out)
+    assert_match(/click->ruby-ui--toast#dismiss|click->ruby-ui--toast#dismiss/, out)
+  end
+
+  def test_icon_renders_per_variant
+    {
+      success: /circle[^>]*r="10"/,
+      info: /M12 16v-4/,
+      warning: /m21\.73 18/,
+      error: /6\.624a2 2 0 0 1 1\.414/,
+      loading: /animate-spin/
+    }.each do |variant, pattern|
+      out = phlex { RubyUI.ToastIcon(variant: variant) }
+      assert_match(pattern, out, "expected #{variant} icon to match #{pattern.inspect}")
+    end
+  end
+
+  def test_icon_default_variant_renders_nothing
+    out = phlex { RubyUI.ToastIcon(variant: :default) }
+    refute_match(/<svg/, out)
+  end
+
+  def test_close_renders_dismiss_action
+    out = phlex { RubyUI.ToastClose() }
+    assert_match(/data-slot="close"/, out)
+    assert_match(/click-&gt;ruby-ui--toast#dismiss|click->ruby-ui--toast#dismiss/, out)
+    assert_match(/sr-only/, out)
+  end
+
+  def test_title_and_description_slot_attrs
+    title_out = phlex { RubyUI.ToastTitle { "Saved" } }
+    desc_out = phlex { RubyUI.ToastDescription { "details" } }
+    assert_match(/data-slot="title"/, title_out)
+    assert_match(/Saved/, title_out)
+    assert_match(/data-slot="description"/, desc_out)
+    assert_match(/details/, desc_out)
+  end
 end