Commit a896333
authored
* [Bug Fix] Fix DropdownMenu docs example: replace nonexistent DialogClose
The 'Non-navigational item' example (added in #427) referenced a
DialogClose component that does not exist in the gem. VisualCodeExample
evaluates the snippet at render time, so it raised NoMethodError and the
whole /docs/dropdown_menu page failed to render.
Close the dialog with the documented pattern instead: a Button wired to
click->ruby-ui--dialog#dismiss (same approach used in dialog_docs.rb).
Fixes #428
* [Bug Fix] Dispatch exceptions through the router so 500s aren't masked as 404
config.exceptions_app pointed at a lambda that always rendered the
not_found action, so every unhandled error (including 500s such as a
raising view) surfaced as a 404. That masked the DropdownMenu render
error behind a misleading 'not found' page.
Point exceptions_app at the router instead; the /404 and /500 routes
already exist, so the response status now matches the actual error and
ErrorsController#internal_server_error is finally reachable.
1 parent d799b7a commit a896333
2 files changed
Lines changed: 5 additions & 2 deletions
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
| |||
43 | 43 | | |
44 | 44 | | |
45 | 45 | | |
46 | | - | |
| 46 | + | |
47 | 47 | | |
48 | 48 | | |
49 | 49 | | |
| |||
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
| |||
24 | 24 | | |
25 | 25 | | |
26 | 26 | | |
27 | | - | |
| 27 | + | |
| 28 | + | |
| 29 | + | |
| 30 | + | |
28 | 31 | | |
29 | 32 | | |
0 commit comments