Commit e6dd60b
committed
[Bug Fix] Move ruby-ui-toaster id from turbo-frame to <ol>
turbo_stream.append('ruby-ui-toaster') was injecting toasts INSIDE
the turbo-frame wrapper but as siblings of the <ol>. The MutationObserver
in toaster_controller watches the <ol>, so new toasts were never
tracked and never animated in.
Drop the turbo-frame wrapper (refresh:morph wasn't actually wired to
flash on navigation anyway) and put the target id on the <ol> itself.
Now Turbo Stream appends land where the controller can see them.1 parent 18a4dd8 commit e6dd60b
2 files changed
Lines changed: 7 additions & 11 deletions
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
| |||
2 | 2 | | |
3 | 3 | | |
4 | 4 | | |
5 | | - | |
6 | | - | |
7 | 5 | | |
8 | 6 | | |
9 | 7 | | |
| |||
38 | 36 | | |
39 | 37 | | |
40 | 38 | | |
41 | | - | |
42 | | - | |
43 | | - | |
44 | | - | |
45 | | - | |
46 | | - | |
| 39 | + | |
| 40 | + | |
| 41 | + | |
47 | 42 | | |
| 43 | + | |
48 | 44 | | |
49 | 45 | | |
50 | 46 | | |
| |||
80 | 76 | | |
81 | 77 | | |
82 | 78 | | |
| 79 | + | |
83 | 80 | | |
84 | 81 | | |
85 | 82 | | |
| |||
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
| |||
3 | 3 | | |
4 | 4 | | |
5 | 5 | | |
6 | | - | |
| 6 | + | |
7 | 7 | | |
8 | | - | |
9 | | - | |
| 8 | + | |
10 | 9 | | |
11 | 10 | | |
12 | 11 | | |
| |||
0 commit comments