Skip to content

feat(combobox): use single chevron-down icon in ComboboxTrigger #475

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
cirdes merged 2 commits into from
Jul 13, 2026
Merged

feat(combobox): use single chevron-down icon in ComboboxTrigger #475

Show file tree
Hide file tree
Changes from 1 commit
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
fa0b940
feat(combobox): use single chevron-down icon in ComboboxTrigger
pierry01 Jul 13, 2026
1128d84
chore(mcp): rebuild registry.json for ComboboxTrigger chevron-down
pierry01 Jul 13, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
5 changes: 1 addition & 4 deletions gem/lib/ruby_ui/combobox/combobox_trigger.rb
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -52,10 +52,7 @@ def icon
stroke_linejoin: "round"
) do |s|
s.path(
d: "m7 15 5 5 5-5"
)
s.path(
d: "m7 9 5-5 5 5"
d: "m6 9 6 6 6-6"
)
end
end
Expand Down
3 changes: 1 addition & 2 deletions gem/test/ruby_ui/combobox_test.rb
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -187,8 +187,7 @@ def test_combobox_badge_trigger_no_chevron

def test_combobox_trigger_chevron_down
output = phlex { RubyUI.ComboboxTrigger(placeholder: "Pick") }
assert_match(/m7 15 5 5 5-5/, output)
assert_match(/m7 9 5-5 5 5/, output)
assert_match(/m6 9 6 6 6-6/, output)
end

def test_combobox_trigger_sets_placeholder_data
Expand Down
Loading