Fix instance self type in default option argument for the belongs_to Active Record

Author: felixefelip

gems/activerecord/6.0/activerecord.rbs

@@ -42,9 +42,11 @@ module ActiveRecord
     extend ::ActiveRecord::Validations::ClassMethods
     extend ::ActiveSupport::Callbacks::ClassMethods
 
+    type belongs_to_default[T] = ^(T) [self: T] -> ::ActiveRecord::Base?
+
     def self.abstract_class=: (bool) -> void
     def self.scope: (Symbol, Proc) ?{ () -> untyped } -> void
-    def self.belongs_to: (Symbol, ?untyped, **untyped) -> void
+    def self.belongs_to: (Symbol, ?untyped, **untyped, ?default: belongs_to_default[instance]) -> void
     def self.has_many: (Symbol, ?untyped, **untyped) -> void
     def self.has_one: (Symbol, ?untyped, **untyped) -> void
     def self.has_and_belongs_to_many: (untyped name, ?untyped? scope, **untyped options) ?{ () -> untyped } -> untyped

gems/activerecord/7.2/_test/activerecord-7.2.rb

@@ -34,6 +34,11 @@ class User < ApplicationRecord
   end
 
   class Article < ApplicationRecord
+    belongs_to :user, default: -> { default_user }
+
+    def default_user
+      User.first
+    end
   end
 
   User.where.missing.to_sql

gems/activerecord/7.2/_test/activerecord-7.2.rbs

@@ -21,5 +21,7 @@ module Test
     class ActiveRecord_Associations_CollectionProxy < ::ActiveRecord::Associations::CollectionProxy
       include ::ActiveRecord::Relation::Methods[Article, Integer]
     end
+
+    def default_user: () -> User?
   end
 end

gems/activerecord/7.2/activerecord.rbs

@@ -42,9 +42,11 @@ module ActiveRecord
     extend ::ActiveRecord::Validations::ClassMethods
     extend ::ActiveSupport::Callbacks::ClassMethods
 
+    type belongs_to_default[T] = ^(T) [self: T] -> ::ActiveRecord::Base?
+
     def self.abstract_class=: (bool) -> void
     def self.scope: (Symbol, Proc) ?{ () -> untyped } -> void
-    def self.belongs_to: (Symbol, ?untyped, **untyped) -> void
+    def self.belongs_to: (Symbol, ?untyped, **untyped, ?default: belongs_to_default[instance]) -> void
     def self.has_many: (Symbol, ?untyped, **untyped) -> void
     def self.has_one: (Symbol, ?untyped, **untyped) -> void
     def self.has_and_belongs_to_many: (untyped name, ?untyped? scope, **untyped options) ?{ () -> untyped } -> untyped

gems/activerecord/8.0/_test/activerecord-8.0.rb

@@ -34,6 +34,11 @@ class User < ApplicationRecord
   end
 
   class Article < ApplicationRecord
+    belongs_to :user, default: -> { default_user }
+
+    def default_user
+      User.first
+    end
   end
 
   User.where.missing.to_sql

gems/activerecord/8.0/_test/activerecord-8.0.rbs

@@ -21,5 +21,7 @@ module Test
     class ActiveRecord_Associations_CollectionProxy < ::ActiveRecord::Associations::CollectionProxy
       include ::ActiveRecord::Relation::Methods[Article, Integer]
     end
+
+    def default_user: () -> User?
   end
 end

gems/activerecord/8.0/activerecord.rbs

@@ -42,9 +42,11 @@ module ActiveRecord
     extend ::ActiveRecord::Validations::ClassMethods
     extend ::ActiveSupport::Callbacks::ClassMethods
 
+    type belongs_to_default[T] = ^(T) [self: T] -> ::ActiveRecord::Base?
+
     def self.abstract_class=: (bool) -> void
     def self.scope: (Symbol, Proc) ?{ () -> untyped } -> void
-    def self.belongs_to: (Symbol, ?untyped, **untyped) -> void
+    def self.belongs_to: (Symbol, ?untyped, **untyped, ?default: belongs_to_default[instance]) -> void
     def self.has_many: (Symbol, ?untyped, **untyped) -> void
     def self.has_one: (Symbol, ?untyped, **untyped) -> void
     def self.has_and_belongs_to_many: (untyped name, ?untyped? scope, **untyped options) ?{ () -> untyped } -> untyped