Conversation
|
@hakanensari Thanks for your contribution! Please follow the instructions below for each change. Available commandsYou can use the following commands by commenting on this PR.
|
|
/merge |
There was a problem hiding this comment.
Pull request overview
Adds minimal RBS stubs for the llhttp gem (v0.6), intended to provide the LLHttp namespace surface needed by downstream signatures.
Changes:
- Add
gems/llhttp/0.6/llhttp.rbswith minimal definitions forLLHttp::Parser,LLHttp::Delegate, andLLHttp::Error. - Add a smoke test under
gems/llhttp/0.6/_test/test.rbexercising the stubbed API.
Reviewed changes
Copilot reviewed 2 out of 2 changed files in this pull request and generated 1 comment.
| File | Description |
|---|---|
| gems/llhttp/0.6/llhttp.rbs | Introduces minimal LLHttp RBS surface (Parser, Delegate, Error). |
| gems/llhttp/0.6/_test/test.rb | Adds a basic runtime usage test to validate the exposed surface. |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
| module LLHttp | ||
| class Error < StandardError | ||
| end |
There was a problem hiding this comment.
PR description references gems/http/.../sig/http.rbs (and http 6.x) as the consumer of these stubs, but in this repo gems/http currently only contains 5.1/http.rbs and there are no LLHttp references under gems/http. Consider updating the PR description to clarify that this stub is intended to satisfy the upstream http gem 6.x bundled signatures (not present in this repo), or add/update the corresponding gems/http entry if that was the intent.
Summary
llhttpgem atgems/llhttp/0.6/.llhttp-ffi): thehttpgem 6.x's gemspec runtime-depends onllhttp(~> 0.6.1), notllhttp-ffi, so most consumers ofhttp's RBS need this one to satisfyCannot find type \LLHttp::Delegate`errors raised fromgems/http/.../sig/http.rbs`.LLHttpnamespace, so the stub here is verbatim what was merged in Add llhttp-ffi gem #1030.Stub surface
Intentionally minimal — limited to what
gems/http/.../sig/http.rbsreferences (LLHttp::Delegate,LLHttp::Parser, plus the parser methodsResponse::Parsercalls). Not an attempt to type the whole gem.Test plan
bin/test gems/llhttp/0.6passes (rbs validate, steep check, untyped-call check).