activerecord: refine create/create! RBS signatures and update tests#1041
Open
kozy4324 wants to merge 1 commit into
Open
activerecord: refine create/create! RBS signatures and update tests#1041kozy4324 wants to merge 1 commit into
kozy4324 wants to merge 1 commit into
Conversation
|
@kozy4324 Thanks for your contribution! Please follow the instructions below for each change. Available commandsYou can use the following commands by commenting on this PR.
|
- Allow passing a block to `create` / `create!` . - Add overloads for `attributes` as an Array of hashes and array return types.
787526e to
d684193
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.

create/create!.attributesas an Array of hashes and array return types.create/create!.Note on file placement
The
create/create!signatures are defined inactiverecord-8.0.rbsrather thanactiverecord.rbs, because these methods are statically defined in Ruby source, not dynamically generated at runtime. Theactiverecord.rbsfile already declaresextend ::ActiveRecord::Persistence::ClassMethodsonActiveRecord::Base, so the type checker resolves them through that module naturally. Is this reasoning correct?