Fix methods defined with invalid encoding are not displayed in completion

Author: ksaito422

lib/irb/completion.rb

@@ -193,8 +193,15 @@ def completion_candidates(preposing, target, postposing, bind:)
 
       # It doesn't make sense to propose commands with other preposing
       commands = [] unless preposing.empty?
-
-      completion_data = retrieve_completion_data(target, bind: bind, doc_namespace: false).compact.map{ |i| i.encode(Encoding.default_external) }
+      @encoding_warning_shown ||= false
+
+      completion_data = retrieve_completion_data(target, bind: bind, doc_namespace: false).compact.map do |i|
+        i.encode(Encoding.default_external)
+      rescue Encoding::UndefinedConversionError
+        warn "Warning: Invalid encoding in method name '#{i}'. can't be converted to the locale #{Encoding.default_external}." unless @encoding_warning_shown
+        @encoding_warning_shown = true
+        nil
+      end.compact
       commands | completion_data
     end
 

test/irb/test_completion.rb

@@ -314,4 +314,43 @@ def test_retrieve_completion_data
       assert_equal(IRB::InputCompletor.retrieve_completion_data('a.abs', bind: bind, doc_namespace: true), 'Integer.abs')
     end
   end
+
+  class InvalidEncodingMethodTest < TestCase
+    def test_invalid_encoding_method_warning
+      invalid_method_name = "b\xff".force_encoding(Encoding::ASCII_8BIT)
+
+      test_obj = Object.new
+      test_obj.define_singleton_method(invalid_method_name) {}
+      test_bind = test_obj.instance_eval { binding }
+
+      original_stderr = $stderr
+      original_encoding = Encoding.default_external
+      original_verbose = $VERBOSE
+
+      begin
+        stderr_buffer = StringIO.new
+        $stderr = stderr_buffer
+        $VERBOSE = nil
+        Encoding.default_external = Encoding::UTF_8
+        $VERBOSE = original_verbose
+
+        completor = IRB::RegexpCompletor.new
+        result = completor.completion_candidates('', 'b', '', bind: test_bind)
+
+        assert_equal("Warning: Invalid encoding in method name 'b\xff'. can't be converted to the locale UTF-8.\n".force_encoding(Encoding::ASCII_8BIT), stderr_buffer.string.force_encoding(Encoding::ASCII_8BIT))
+        assert_not_include(result, nil)
+
+        stderr_buffer.truncate(0)
+        stderr_buffer.rewind
+        stderr_buffer = StringIO.new
+
+        completor.completion_candidates('', 'b', '', bind: test_bind)
+        assert_empty(stderr_buffer.string)
+      ensure
+        $stderr = original_stderr
+        Encoding.default_external = original_encoding
+        $VERBOSE = original_verbose
+      end
+    end
+  end
 end