You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
I had some time last night so I decided to see how hard it would be to implement a sort_keys option to the generator. This adds support to the C extension, Java extension and truffleruby implementation.
THanks for handling this, however in lieu of #1038, I think a sort_key option shouldn't be a a simple boolean, but should also accept a proc so we can implement custom sorting semantic.
THanks for handling this, however in lieu of #1038, I think a sort_key option shouldn't be a a simple boolean, but should also accept a proc so we can implement custom sorting semantic.
No problem. I can try to take a stab at that tonight night/this weekend. I think it should be as simple as accepting a proc and passing it to obj.sort_by when generating the JSON.
I added the ability to pass a Proc which accepts two [key, value] pairs to allow for arbitrary sorting. I'm not entirely sure if this is what you had in mind but it allows for maximum flexibility. I'm not totally sure if that's warranted but I ran with that assumption. I'm happy to make changes as requested.
Note that a boolean (true) is still supported which will sort keys lexicographically.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
I had some time last night so I decided to see how hard it would be to implement a sort_keys option to the generator. This adds support to the C extension, Java extension and truffleruby implementation.