Skip to content

Avoid Float out of range warning for clearly underflowing numbers #1044

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
znz wants to merge 1 commit into
base: master
Choose a base branch
from
+7 −0
Open

Avoid Float out of range warning for clearly underflowing numbers #1044

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
7 changes: 7 additions & 0 deletions ext/json/ext/parser/parser.c
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -1133,6 +1133,13 @@ static inline VALUE json_decode_float(JSON_ParserConfig *config, uint64_t mantis
}

if (RB_UNLIKELY(mantissa_digits > 18 || mantissa_digits + exponent < -307)) {
// If the value is so small that it definitely underflows to 0.0, return early
// to avoid triggering a "Float out of range" warning from rb_cstr_to_dbl.
// When mantissa_digits + exponent < -324, value < 10^(-324) < DBL_TRUE_MIN/2,
// so it rounds to 0 in IEEE 754 round-to-nearest.
if (RB_UNLIKELY(mantissa_digits + exponent < -324)) {
return rb_float_new(negative ? -0.0 : 0.0);
}
return json_decode_large_float(start, end - start);
}

Expand Down
Loading