Switch node ID flag to a positive condition

Author: headius

.github/workflows/java-wasm-bindings.yml

@@ -28,7 +28,7 @@ jobs:
           bundler-cache: true
 
       - name: rake templates
-        run: PRISM_EXCLUDE_PRETTYPRINT=1 PRISM_OMIT_NODE_ID=1 bundle exec rake templates
+        run: PRISM_EXCLUDE_PRETTYPRINT=1 PRISM_INCLUDE_NODE_ID=false bundle exec rake templates
 
       - name: Set up WASI-SDK
         run: |

templates/java/api/src/main/java-templates/org/ruby_lang/prism/Loader.java.erb

@@ -324,12 +324,12 @@ public class Loader {
     }
 
     <%-
-    base_params = [*("nodeId" unless Prism::Template::OMIT_NODE_ID), "startOffset", "length"]
+    base_params = [*("nodeId" if Prism::Template::INCLUDE_NODE_ID), "startOffset", "length"]
     base_params_sig = base_params.map { "int #{_1}" }.join(", ")
     -%>
     private Nodes.Node loadNode() {
         int type = buffer.get() & 0xFF;
-        <%- unless Prism::Template::OMIT_NODE_ID -%>
+        <%- if Prism::Template::INCLUDE_NODE_ID -%>
         int nodeId = loadVarUInt();
         <%- end -%>
         int startOffset = loadVarUInt();
@@ -341,7 +341,7 @@ public class Loader {
             case <%= index + 1 %>:
             <%-
             params = []
-            params << "nodeId" unless Prism::Template::OMIT_NODE_ID
+            params << "nodeId" if Prism::Template::INCLUDE_NODE_ID
             params << "startOffset" << "length"
             params << "buffer.getInt()" << "null" if node.needs_serialized_length?
             params << "loadFlags()" if node.flags

templates/java/api/src/main/java-templates/org/ruby_lang/prism/Nodes.java.erb

@@ -88,14 +88,14 @@ public abstract class Nodes {
 
         public static final Node[] EMPTY_ARRAY = {};
 
-        <%- unless Prism::Template::OMIT_NODE_ID -%>
+        <%- if Prism::Template::INCLUDE_NODE_ID -%>
         public final int nodeId;
         <%- end -%>
         public final int startOffset;
         public final int length;
         private boolean newLineFlag = false;
 
-        <%- unless Prism::Template::OMIT_NODE_ID -%>
+        <%- if Prism::Template::INCLUDE_NODE_ID -%>
         public Node(int nodeId, int startOffset, int length) {
             this.nodeId = nodeId;
         <%- else -%>
@@ -245,7 +245,7 @@ public abstract class Nodes {
 
         <%-
           params = []
-          params << "int nodeId" unless Prism::Template::OMIT_NODE_ID
+          params << "int nodeId" if Prism::Template::INCLUDE_NODE_ID
           params << "int startOffset" << "int length"
           if node.needs_serialized_length?
             params << "int serializedLength"
@@ -255,7 +255,7 @@ public abstract class Nodes {
           params.concat(node.semantic_fields.map { |field| "#{field.java_type} #{field.name}" })
         -%>
         public <%= node.name -%>(<%= params.join(", ") %>) {
-        <%- unless Prism::Template::OMIT_NODE_ID -%>
+        <%- if Prism::Template::INCLUDE_NODE_ID -%>
             super(nodeId, startOffset, length);
         <%- else -%>
             super(startOffset, length);
@@ -280,7 +280,7 @@ public abstract class Nodes {
 
         public <%= node.name -%> getNonLazy() {
             if (isLazy()) {
-                return loader.createDefNodeFromSavedPosition(<%= "nodeId, " unless Prism::Template::OMIT_NODE_ID %>startOffset, length, -serializedLength);
+                return loader.createDefNodeFromSavedPosition(<%= "nodeId, " if Prism::Template::INCLUDE_NODE_ID %>startOffset, length, -serializedLength);
             } else {
                 return this;
             }

templates/src/serialize.c.erb

@@ -73,7 +73,7 @@ static void
 pm_serialize_node(pm_parser_t *parser, pm_node_t *node, pm_buffer_t *buffer) {
     pm_buffer_append_byte(buffer, (uint8_t) PM_NODE_TYPE(node));
 
-    <%- unless Prism::Template::OMIT_NODE_ID -%>
+    <%- if Prism::Template::INCLUDE_NODE_ID -%>
     pm_buffer_append_varuint(buffer, node->node_id);
     <%- end -%>
     pm_serialize_location(&node->location, buffer);

templates/template.rb

@@ -11,7 +11,7 @@ module Template # :nodoc: all
 
     JAVA_BACKEND = ENV["PRISM_JAVA_BACKEND"] || "default"
     JAVA_IDENTIFIER_TYPE = JAVA_BACKEND == "truffleruby" ? "String" : "byte[]"
-    OMIT_NODE_ID = ENV.fetch("PRISM_OMIT_NODE_ID", false)
+    INCLUDE_NODE_ID = ENV.fetch("PRISM_INCLUDE_NODE_ID", "true") != "false"
 
     COMMON_FLAGS_COUNT = 2