Merge pull request #3531 from Earlopain/parser-translator-tests-explicit-skip

Be explicit in tests which files `parser` can't parse

Author: kddnewton

Gemfile.lock

@@ -15,7 +15,7 @@ GEM
       mini_portile2 (~> 2.8.2)
       racc (~> 1.4)
     onigmo (0.1.0)
-    parser (3.3.7.2)
+    parser (3.3.7.4)
       ast (~> 2.4.1)
       racc
     power_assert (2.0.5)

test/prism/ruby/parser_test.rb

@@ -56,6 +56,16 @@ def ==(other)
 
 module Prism
   class ParserTest < TestCase
+    # These files contain code with valid syntax that can't be parsed.
+    skip_syntax_error = [
+      # alias/undef with %s(abc) symbol literal
+      "alias.txt",
+      "seattlerb/bug_215.txt",
+
+      # 1.. && 2
+      "ranges.txt",
+    ]
+
     # These files contain code that is being parsed incorrectly by the parser
     # gem, and therefore we don't want to compare against our translation.
     skip_incorrect = [
@@ -133,7 +143,7 @@ class ParserTest < TestCase
       "whitequark/space_args_block.txt"
     ]
 
-    Fixture.each do |fixture|
+    Fixture.each(except: skip_syntax_error) do |fixture|
       define_method(fixture.test_name) do
         assert_equal_parses(
           fixture,
@@ -190,11 +200,7 @@ def assert_equal_parses(fixture, compare_asts: true, compare_tokens: true, compa
       parser.diagnostics.all_errors_are_fatal = true
 
       expected_ast, expected_comments, expected_tokens =
-        begin
-          ignore_warnings { parser.tokenize(buffer) }
-        rescue ArgumentError, Parser::SyntaxError
-          return
-        end
+        ignore_warnings { parser.tokenize(buffer) }
 
       actual_ast, actual_comments, actual_tokens =
         ignore_warnings { Prism::Translation::Parser33.new.tokenize(buffer) }