Ensure Source#offsets is set correctly in all cases

* See #3861

Author: eregon

lib/prism/parse_result.rb

@@ -26,7 +26,8 @@ class Source
     # source is a subset of a larger source or if this is an eval. offsets is an
     # array of byte offsets for the start of each line in the source code, which
     # can be calculated by iterating through the source code and recording the
-    # byte offset whenever a newline character is encountered.
+    # byte offset whenever a newline character is encountered.  The first
+    # element is always 0 to mark the first line.
     #--
     #: (String source, Integer start_line, Array[Integer] offsets) -> Source
     def self.for(source, start_line, offsets)

rbi/generated/prism/dsl.rbi

@@ -5,7 +5,7 @@ module Prism
   # The DSL module provides a set of methods that can be used to create prism
   # nodes in a more concise manner. For example, instead of writing:
   #
-  #     source = Prism::Source.for("[1]", 1, [])
+  #     source = Prism::Source.for("[1]", 1, [0])
   #
   #     Prism::ArrayNode.new(
   #       source,
@@ -62,7 +62,7 @@ module Prism
     #--
     #: (String string) -> Source
     def source(string)
-      Source.for(string, 1, [])
+      Source.for(string, 1, build_offsets(string))
     end
 
     # Create a new Location object.
@@ -136,7 +136,7 @@ module Prism
     #--
     #: () -> Source
     def default_source
-      Source.for("", 1, [])
+      Source.for("", 1, [0])
     end
 
     # The default location object that gets attached to nodes if no location is
@@ -154,5 +154,19 @@ module Prism
     def default_node(source, location)
       MissingNode.new(source, -1, location, 0)
     end
+
+    private
+
+    # Build the newline byte offset array for the given source string.
+    #--
+    #: (String source) -> Array[Integer]
+    def build_offsets(source)
+      offsets = [0]
+      start = 0
+      while (index = source.byteindex("\n", start))
+        offsets << (start = index + 1)
+      end
+      offsets
+    end
   end
 end