Remove generated types from checkin

Author: kddnewton

.gitattributes

@@ -8,9 +8,6 @@ test/prism/fixtures/unparser/**/*.txt linguist-vendored
 test/prism/fixtures/whitequark/**/*.txt linguist-vendored
 test/prism/snapshots/**/*.txt linguist-generated
 
-rbi/generated/**/*.rbi linguist-generated
-sig/generated/**/*.rbs linguist-generated
-
 # All .rb files should have LF line ending, even on Windows, regardless of the git config core.autocrlf value.
 # All .txt should have their line endings as committed in the repository (there are some intentional CR in there),
 # regardless of the git config core.autocrlf value.

.github/workflows/main.yml

@@ -50,6 +50,8 @@ jobs:
       with:
         ruby-version: "3.4"
         bundler-cache: true
+    - name: Generate types
+      run: bundle exec rake typecheck:rbs_inline typecheck:rbi
     - name: Check Sorbet
       run: bundle exec rake typecheck:tapioca typecheck:sorbet
     - name: Check Steep

.gitignore

@@ -60,9 +60,11 @@ out.svg
 /src/serialize.c
 /src/token_type.c
 /src/**/*.o
+/rbi/generated/
 /rbi/prism/dsl.rbi
 /rbi/prism/node.rbi
 /rbi/prism/visitor.rbi
+/sig/generated/
 
 compile_commands.json
 .cache/

Rakefile

@@ -23,7 +23,7 @@ task compile_no_debug: %i[make_no_debug compile]
 task compile_minimal: %i[make_minimal compile]
 
 # decorate the gem build task with prerequisites
-task build: [:check_manifest, :templates]
+task build: [:check_manifest, :templates, "typecheck:rbs_inline", "typecheck:rbi"]
 
 # the C extension
 task "compile:prism" => ["templates"] # must be before the ExtensionTask is created

prism.gemspec

@@ -111,53 +111,11 @@ Gem::Specification.new do |spec|
     "lib/prism/translation/ruby_parser.rb",
     "lib/prism/visitor.rb",
     "prism.gemspec",
-    "rbi/generated/prism.rbi",
-    "rbi/generated/prism/compiler.rbi",
-    "rbi/generated/prism/desugar_compiler.rbi",
-    "rbi/generated/prism/dispatcher.rbi",
-    "rbi/generated/prism/dot_visitor.rbi",
-    "rbi/generated/prism/dsl.rbi",
-    "rbi/generated/prism/inspect_visitor.rbi",
-    "rbi/generated/prism/lex_compat.rbi",
-    "rbi/generated/prism/mutation_compiler.rbi",
-    "rbi/generated/prism/node.rbi",
-    "rbi/generated/prism/node_ext.rbi",
-    "rbi/generated/prism/parse_result.rbi",
-    "rbi/generated/prism/pattern.rbi",
-    "rbi/generated/prism/reflection.rbi",
-    "rbi/generated/prism/relocation.rbi",
-    "rbi/generated/prism/serialize.rbi",
-    "rbi/generated/prism/string_query.rbi",
-    "rbi/generated/prism/translation.rbi",
-    "rbi/generated/prism/visitor.rbi",
-    "rbi/generated/prism/parse_result/comments.rbi",
-    "rbi/generated/prism/parse_result/errors.rbi",
-    "rbi/generated/prism/parse_result/newlines.rbi",
+    *Dir.glob("rbi/generated/**/*.rbi"),
     "rbi/prism/translation/parser.rbi",
     "rbi/prism/translation/parser_versions.rbi",
     "rbi/prism/translation/ripper.rbi",
-    "sig/generated/prism.rbs",
-    "sig/generated/prism/compiler.rbs",
-    "sig/generated/prism/desugar_compiler.rbs",
-    "sig/generated/prism/dispatcher.rbs",
-    "sig/generated/prism/dot_visitor.rbs",
-    "sig/generated/prism/dsl.rbs",
-    "sig/generated/prism/inspect_visitor.rbs",
-    "sig/generated/prism/lex_compat.rbs",
-    "sig/generated/prism/mutation_compiler.rbs",
-    "sig/generated/prism/node.rbs",
-    "sig/generated/prism/node_ext.rbs",
-    "sig/generated/prism/parse_result.rbs",
-    "sig/generated/prism/pattern.rbs",
-    "sig/generated/prism/reflection.rbs",
-    "sig/generated/prism/relocation.rbs",
-    "sig/generated/prism/serialize.rbs",
-    "sig/generated/prism/string_query.rbs",
-    "sig/generated/prism/translation.rbs",
-    "sig/generated/prism/visitor.rbs",
-    "sig/generated/prism/parse_result/comments.rbs",
-    "sig/generated/prism/parse_result/errors.rbs",
-    "sig/generated/prism/parse_result/newlines.rbs",
+    *Dir.glob("sig/generated/**/*.rbs"),
     "src/diagnostic.c",
     "src/encoding.c",
     "src/node.c",