Dynamic constant writes on operator writes

Author: kddnewton

src/prism.c

@@ -21343,6 +21343,10 @@ parse_expression_infix(pm_parser_t *parser, pm_node_t *node, pm_binding_power_t
                     pm_node_t *value = parse_assignment_value(parser, previous_binding_power, binding_power, flags, PM_ERR_EXPECT_EXPRESSION_AFTER_AMPAMPEQ, (uint16_t) (depth + 1));
                     pm_node_t *write = UP(pm_constant_and_write_node_create(parser, (pm_constant_read_node_t *) node, &token, value));
 
+                    if (context_def_p(parser)) {
+                        pm_parser_err_node(parser, write, PM_ERR_WRITE_TARGET_IN_METHOD);
+                    }
+
                     return parse_shareable_constant_write(parser, write);
                 }
                 case PM_INSTANCE_VARIABLE_READ_NODE: {
@@ -21468,6 +21472,10 @@ parse_expression_infix(pm_parser_t *parser, pm_node_t *node, pm_binding_power_t
                     pm_node_t *value = parse_assignment_value(parser, previous_binding_power, binding_power, flags, PM_ERR_EXPECT_EXPRESSION_AFTER_PIPEPIPEEQ, (uint16_t) (depth + 1));
                     pm_node_t *write = UP(pm_constant_or_write_node_create(parser, (pm_constant_read_node_t *) node, &token, value));
 
+                    if (context_def_p(parser)) {
+                        pm_parser_err_node(parser, write, PM_ERR_WRITE_TARGET_IN_METHOD);
+                    }
+
                     return parse_shareable_constant_write(parser, write);
                 }
                 case PM_INSTANCE_VARIABLE_READ_NODE: {
@@ -21603,6 +21611,10 @@ parse_expression_infix(pm_parser_t *parser, pm_node_t *node, pm_binding_power_t
                     pm_node_t *value = parse_assignment_value(parser, previous_binding_power, binding_power, flags, PM_ERR_EXPECT_EXPRESSION_AFTER_OPERATOR, (uint16_t) (depth + 1));
                     pm_node_t *write = UP(pm_constant_operator_write_node_create(parser, (pm_constant_read_node_t *) node, &token, value));
 
+                    if (context_def_p(parser)) {
+                        pm_parser_err_node(parser, write, PM_ERR_WRITE_TARGET_IN_METHOD);
+                    }
+
                     return parse_shareable_constant_write(parser, write);
                 }
                 case PM_INSTANCE_VARIABLE_READ_NODE: {

test/prism/errors/constant_operator_assignment_in_method.txt

@@ -0,0 +1,9 @@
+def foo();A+=1;end
+          ^~~~ dynamic constant assignment
+
+def bar();B||=1;end
+          ^~~~~ dynamic constant assignment
+
+def baz();C&&=1;end
+          ^~~~~ dynamic constant assignment
+