Use slices for more internal locations

Author: kddnewton

config.yml

@@ -1767,7 +1767,7 @@ def visit_symbol_node(node)
             end
           else
             parts =
-              if node.value == ""
+              if node.value_loc.nil?
                 []
               elsif node.value.include?("\n")
                 string_nodes_from_line_continuations(node.unescaped, node.value, node.value_loc.start_offset, node.opening)

lib/prism/translation/parser/compiler.rb

@@ -19,7 +19,6 @@ class Lexer
         TYPES = {
           # These tokens should never appear in the output of the lexer.
           MISSING: nil,
-          NOT_PROVIDED: nil,
           EMBDOC_END: nil,
           EMBDOC_LINE: nil,
 

lib/prism/translation/parser/lexer.rb

@@ -3106,14 +3106,13 @@ def visit_super_node(node)
       # :foo
       # ^^^^
       def visit_symbol_node(node)
-        if (opening = node.opening)&.match?(/^%s|['"]:?$/)
+        if node.value_loc.nil?
+          bounds(node.location)
+          on_dyna_symbol(on_string_content)
+        elsif (opening = node.opening)&.match?(/^%s|['"]:?$/)
           bounds(node.value_loc)
-          content = on_string_content
-
-          if !(value = node.value).empty?
-            content = on_string_add(content, on_tstring_content(value))
-          end
-
+          content = on_string_add(on_string_content, on_tstring_content(node.value))
+          bounds(node.location)
           on_dyna_symbol(content)
         elsif (closing = node.closing) == ":"
           bounds(node.location)

lib/prism/translation/ripper.rb

@@ -8,6 +8,6 @@
         └── @ SymbolNode (location: (1,0)-(1,3))
             ├── flags: newline, static_literal, forced_us_ascii_encoding
             ├── opening_loc: (1,0)-(1,2) = ":'"
-            ├── value_loc: (1,2)-(1,2) = ""
+            ├── value_loc: ∅
             ├── closing_loc: (1,2)-(1,3) = "'"
             └── unescaped: ""

snapshots/seattlerb/symbol_empty.txt

@@ -129,7 +129,7 @@
         │   │       └── @ SymbolNode (location: (17,4)-(20,0))
         │   │           ├── flags: static_literal, forced_us_ascii_encoding
         │   │           ├── opening_loc: (17,4)-(18,0) = "%s\n"
-        │   │           ├── value_loc: (18,0)-(18,0) = ""
+        │   │           ├── value_loc: ∅
         │   │           ├── closing_loc: (19,0)-(20,0) = "\n"
         │   │           └── unescaped: ""
         │   ├── closing_loc: ∅

snapshots/spanning_heredoc_newlines.txt

@@ -620,7 +620,7 @@
         ├── @ SymbolNode (location: (48,0)-(48,3))
         │   ├── flags: newline, static_literal
         │   ├── opening_loc: (48,0)-(48,2) = ":\""
-        │   ├── value_loc: (1,0)-(1,0) = ""
+        │   ├── value_loc: ∅
         │   ├── closing_loc: (48,2)-(48,3) = "\""
         │   └── unescaped: ""
         ├── @ RegularExpressionNode (location: (49,0)-(49,5))

snapshots/unparser/corpus/literal/literal.txt

@@ -31,10 +31,6 @@ pm_token_type_human(pm_token_type_t token_type) {
     switch (token_type) {
         case PM_TOKEN_EOF:
             return "end-of-input";
-        case PM_TOKEN_MISSING:
-            return "missing token";
-        case PM_TOKEN_NOT_PROVIDED:
-            return "not provided token";
         case PM_TOKEN_AMPERSAND:
             return "'&'";
         case PM_TOKEN_AMPERSAND_AMPERSAND:

src/prism.c

@@ -45,19 +45,19 @@ def test_embdoc_ending
     def test_unterminated_string_closing
       statement = Prism.parse_statement("'hello")
       assert_equal statement.unescaped, "hello"
-      assert_empty statement.closing
+      assert_nil statement.closing
     end
 
     def test_unterminated_interpolated_string_closing
       statement = Prism.parse_statement('"hello')
       assert_equal statement.unescaped, "hello"
-      assert_empty statement.closing
+      assert_nil statement.closing
     end
 
     def test_unterminated_empty_string_closing
       statement = Prism.parse_statement('"')
       assert_empty statement.unescaped
-      assert_empty statement.closing
+      assert_nil statement.closing
     end
 
     def test_invalid_message_name