Validate RescueNode

Author: thomasmarshall

config.yml

@@ -4327,9 +4327,7 @@ nodes:
           - ConstantPathTargetNode
           - CallTargetNode
           - IndexTargetNode
-          - on error: BackReferenceReadNode # => begin; rescue => $&; end
-          - on error: NumberedReferenceReadNode # => begin; rescue => $1; end
-          - on error: ErrorRecoveryNode # begin; rescue =>; end
+          - on error: ErrorRecoveryNode
       - name: then_keyword_loc
         type: location?
       - name: statements

src/prism.c

@@ -14423,6 +14423,9 @@ parse_rescues(pm_parser_t *parser, size_t opening_newline_index, const pm_token_
                 pm_node_t *reference = parse_expression(parser, PM_BINDING_POWER_INDEX, false, false, PM_ERR_RESCUE_VARIABLE, (uint16_t) (depth + 1));
                 reference = parse_target(parser, reference, false, false);
 
+                PM_VALIDATE_NODE_TYPE(parser, reference,
+                    PM_LOCAL_VARIABLE_TARGET_NODE, PM_INSTANCE_VARIABLE_TARGET_NODE, PM_CLASS_VARIABLE_TARGET_NODE, PM_GLOBAL_VARIABLE_TARGET_NODE,
+                    PM_CONSTANT_TARGET_NODE, PM_CONSTANT_PATH_TARGET_NODE, PM_CALL_TARGET_NODE, PM_INDEX_TARGET_NODE);
                 pm_rescue_node_reference_set(rescue, reference);
                 break;
             }
@@ -14453,6 +14456,9 @@ parse_rescues(pm_parser_t *parser, size_t opening_newline_index, const pm_token_
                             pm_node_t *reference = parse_expression(parser, PM_BINDING_POWER_INDEX, false, false, PM_ERR_RESCUE_VARIABLE, (uint16_t) (depth + 1));
                             reference = parse_target(parser, reference, false, false);
 
+                            PM_VALIDATE_NODE_TYPE(parser, reference,
+                                PM_LOCAL_VARIABLE_TARGET_NODE, PM_INSTANCE_VARIABLE_TARGET_NODE, PM_CLASS_VARIABLE_TARGET_NODE, PM_GLOBAL_VARIABLE_TARGET_NODE,
+                                PM_CONSTANT_TARGET_NODE, PM_CONSTANT_PATH_TARGET_NODE, PM_CALL_TARGET_NODE, PM_INDEX_TARGET_NODE);
                             pm_rescue_node_reference_set(rescue, reference);
                             break;
                         }

test/prism/result/error_recovery_test.rb

@@ -203,15 +203,17 @@ def test_rescue_node_reference_back_reference
       refute result.success?
 
       node = result.value.statements.body.first.rescue_clause
-      assert_kind_of BackReferenceReadNode, node.reference
+      assert_kind_of ErrorRecoveryNode, node.reference
+      assert_kind_of BackReferenceReadNode, node.reference.child
     end
 
     def test_rescue_node_reference_numbered_reference
       result = Prism.parse("begin; rescue => $1; end")
       refute result.success?
 
       node = result.value.statements.body.first.rescue_clause
-      assert_kind_of NumberedReferenceReadNode, node.reference
+      assert_kind_of ErrorRecoveryNode, node.reference
+      assert_kind_of NumberedReferenceReadNode, node.reference.child
     end
 
     def test_rescue_node_reference_missing
@@ -220,6 +222,7 @@ def test_rescue_node_reference_missing
 
       node = result.value.statements.body.first.rescue_clause
       assert_kind_of ErrorRecoveryNode, node.reference
+      assert_nil node.reference.child
     end
   end
 end