Merge pull request #3985 from ruby/fix-overflow

kddnewton · web-flow · commit fb8f6fa10400 · 2026-03-11T00:44:43.000-04:00
Fix reading past end of target names
diff --git a/src/regexp.c b/src/regexp.c
@@ -436,7 +436,7 @@ typedef enum {
  */
 static inline bool
 pm_regexp_property_name_matches(const uint8_t *name, size_t length, const char *target) {
-    return target[length] == '\0' && pm_strncasecmp(name, (const uint8_t *) target, length) == 0;
+    return strlen(target) == length && pm_strncasecmp(name, (const uint8_t *) target, length) == 0;
 }
 
 /**

Original file line number	Diff line number	Diff line change
`@@ -436,7 +436,7 @@ typedef enum {`
`436`	`436`	`*/`
`437`	`437`	`static inline bool`
`438`	`438`	`pm_regexp_property_name_matches(const uint8_t name, size_t length, const char target) {`
`439`		`- return target[length] == '\0' && pm_strncasecmp(name, (const uint8_t *) target, length) == 0;`
	`439`	`+ return strlen(target) == length && pm_strncasecmp(name, (const uint8_t *) target, length) == 0;`
`440`	`440`	`}`
`441`	`441`
`442`	`442`	`/**`