Conversation
adf14eb to
c08eebf
Compare
ParadoxV5
left a comment
ParadoxV5
left a comment
There was a problem hiding this comment.
- Fixes #2716
prism-0.26.0.gem was accidentally checked in; the CI is also complaining about it.
I put #2711 (comment) on hold for observing the progress of #2716 first.
In order to override GNU make’s default ARFLAGS without affecting extconf.rb, we’ll have to either
- send these preferences via CLI args rather than env vars (CLI:
make KEY=VALUErather thanKEY=VALUE make), or - rename the
ARFLAGSvariable in theMakefile
| CC ?= cc | ||
| AR ?= ar |
There was a problem hiding this comment.
As discovered in #2711 (comment), CC ?= cc and AR ?= ar has no effect, whether run from make directly (because GNU make already preconfigures them to cc and ar respectively) or from extconf.rb (as it’ll override them with rbconfig values)
| CC ?= cc | |
| AR ?= ar |
There was a problem hiding this comment.
I agree with you in theory, but something else must be going on here, because after lots of back and forth with @forthrin this is what finally resolved the issue. I'm assuming there's something else here going on.
| # up as much of the configuration to the configuration that built the current | ||
| # version of Ruby as possible. | ||
| require "rbconfig" | ||
| env = RbConfig::CONFIG.slice("SOEXT", "CPPFLAGS", "CFLAGS", "CC", "AR", "ARFLAGS", "MAKEDIRS", "RMALL") |
There was a problem hiding this comment.
2 participants
No description provided.