[Bug #21345] Fix accepting multiple rest patterns with leading match#3564
Merged
Conversation
Earlopain
force-pushed
the
implicit-rest-leading
branch
from
May 19, 2025 11:15
3020fe9 to
587867d
Compare
Collaborator
Author
|
Openend https://bugs.ruby-lang.org/issues/21352 for valgrind |
Earlopain
force-pushed
the
implicit-rest-leading
branch
from
June 30, 2025 12:56
587867d to
de56fa4
Compare
rafaelfranca
approved these changes
Jul 16, 2025
Collaborator
|
Code is correct, but as this also closes a bug in the ruby issue tracker, and I don't know if that requires us to commit to Ruby, I'm not going to merge. @tenderlove @eileencodes what is the process here? |
Member
|
It will sync to Ruby so it's fine to merge here. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
https://bugs.ruby-lang.org/issues/21345
Related: