Trusted publishing workflows#3680
Conversation
af9adcc to
19ad6e1
Compare
kddnewton
left a comment
kddnewton
left a comment
There was a problem hiding this comment.
This all looks good. I put a couple of comments on here for things that I saw, but obviously we won't know until we attempt to publish something.
| path: | | ||
| ~/.cargo/registry | ||
| ~/.cargo/git | ||
| target |
There was a problem hiding this comment.
I think this should be rust/target, since it builds in a subdirectory
There was a problem hiding this comment.
I got this from here. Should it also change? Or is this somehow different?
There was a problem hiding this comment.
I guess since I removed caching, this doesn't matter. Though I still wonder about the other workflow pointing at the right location.
|
Oh, for the gem you definitly need some setup on rubygems.org for it to work if you didn't do that already: https://guides.rubygems.org/trusted-publishing/adding-a-publisher/ |
Ya, I've already set this up with crates.io, npmjs, and RubyGems.org. Just need to get the workflow files in shape 😄 |
4fb0710 to
ed3bec4
Compare
70f6c11 to
f224797
Compare
|
I think I've addressed most of the feedback. Please take another look! 🙇 |
|
🤞 |
3 participants
I'm working on adding trusted publishing workflows so we can automate gem / crate / npm package releases. Once we get this working correctly, we can simply push a tag to GitHub, and all of the packages will be released automatically.
The plan is to add one workflow per publisher.
I set up the RubyGems workflow based on other gems that we publish.
I'm less confident about the other workflows, but I used this documentation for crates.io as well as this documentation for npm.
I based the crates workflow and the npm workflow off of their respective CI workflows, but I'd really appreciate reviews from other folks. Once we have something to release, we can test these workflows. 😄