[rust] add len function for NodeList#3701
Merged
Merged
Conversation
froydnj
changed the title
size function for NodeListlen function for NodeList
kddnewton
approved these changes
Nov 2, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Getting the length of a
NodeListcurrently requires usingcount():https://github.com/fables-tales/rubyfmt/blob/ab02a7888892bbc34d05a70e304d95806f8a83f4/librubyfmt/src/format_prism.rs#L659-L660
I think the compiler might be smart enough to unroll the loop and collapse down the iterations to compute the actual size in constant time, but why create work for the compiler if you don't have to?