Prevent an infinite loop parsing a capture name#3732
Merged
Conversation
Collaborator
|
Thanks, can you add a test for this? In (I guess some other parsers we test against may correctly reject this code. If that is the case, simply excluding this new file for them is fine) |
Earlopain
approved these changes
Dec 13, 2025
Earlopain
left a comment
Earlopain
left a comment
Collaborator
There was a problem hiding this comment.
Sorry for the delay. Since this seems to be correctly implemented everywhere but prism, I just dropped the test. I now feel that wasn't such a bright idea after all.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #3729.