Clean up test excludes#3774
Merged
Merged
Conversation
Otherwise, it uses the latest prism version
Earlopain
force-pushed
the
unskip-tests
branch
6 times, most recently
from
December 2, 2025 11:56
b66c79c to
729a02d
Compare
Collaborator
Author
|
The first commit fixes an issue where the ripper translator parses code with the latest version instead of the currently running version. Found while cleaning up the excludes. Also openend https://bugs.ruby-lang.org/issues/21756. The rest are as far as I can tell something that should be changed in prism. |
Earlopain
marked this pull request as ready for review
December 2, 2025 12:03
Earlopain
force-pushed
the
unskip-tests
branch
from
December 2, 2025 12:24
729a02d to
1f198ea
Compare
Mostly not having to list version-specific excludes when testing against ripper/parse.y Also don't test new syntax additions against the parser gems. The version support for them may (or may not) be expanded but we shouldn't bother while the ruby version hasn't even released yet. (ruby_parser translation is not versioned, so let as is for now) I also removed excludes that have since been implemented by parse.y
Earlopain
force-pushed
the
unskip-tests
branch
from
December 2, 2025 13:41
1f198ea to
e5a0221
Compare
kddnewton
approved these changes
Dec 2, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Mostly not having to list version-specific excludes when testing against ripper/parse.y
I also removed excludes that have since been implemented by parse.y