Fix assertions in location_test.rb#3816
Merged
Merged
Conversation
eregon
commented
Dec 16, 2025
eregon
commented
Member
- assert_raise's 2nd argument is the failure message, shown when the expected exception is not raised. It's not the expected message. See assert_raise is error-prone test-unit/test-unit#347
* assert_raise's 2nd argument is the failure message, shown when the expected exception is not raised. It's not the expected message. See test-unit/test-unit#347
eregon
force-pushed
the
fix-location_test
branch
from
December 16, 2025 14:40
694c219 to
e3df994
Compare
Earlopain
approved these changes
Dec 17, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.