Adapt ParametersNode#signature to ErrorRecoveryNode#4064
Merged
Conversation
kddnewton
approved these changes
Apr 4, 2026
kddnewton
previously requested changes
Apr 4, 2026
kddnewton
left a comment
kddnewton
left a comment
Collaborator
There was a problem hiding this comment.
The test failure should be looked into...
No need to list them all out anymore, it's just a single possibility now
Earlopain
force-pushed
the
parameters-signature-recovery
branch
from
April 4, 2026 11:09
20e1411 to
893f273
Compare
Collaborator
Author
|
I guess ruby has a copy of |
eregon
approved these changes
Apr 5, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No need to list them all out anymore, it's just a single possibility now