Skip to content

Fix Java version mismatch errors#286

Merged
ydah merged 2 commits into
ruby:masterfrom
ydah:fix-ci-for-jruby
Jun 8, 2025
Merged

Fix Java version mismatch errors#286
ydah merged 2 commits into
ruby:masterfrom
ydah:fix-ci-for-jruby

Conversation

@ydah
Copy link
Copy Markdown
Member

@ydah ydah commented May 24, 2025

Fixes: #288

We are trying to compile for Java 8 with -target 1.8 -source 1.8 at compile time but the JRuby jar file (jruby.jar) is compiled with Java 21

https://github.com/ruby/racc/actions/runs/15127129930/job/42521128864

  • Error message: class file has wrong version 65.0, should be 61.0
  • version 65.0 = Java 21
  • version 61.0 = Java 17

@ydah ydah force-pushed the fix-ci-for-jruby branch 3 times, most recently from cd097f9 to 136913f Compare May 24, 2025 14:19
@ydah ydah force-pushed the fix-ci-for-jruby branch 2 times, most recently from 77ccb43 to 2564fbf Compare June 8, 2025 09:13
We are trying to compile for Java 8 with `-target 1.8 -source 1.8 `at compile time
but the JRuby jar file (jruby.jar) is compiled with Java 21

- Error message: `class file has wrong version 65.0, should be 61.0`
- version 65.0 = Java 21
- version 61.0 = Java 17
@ydah ydah force-pushed the fix-ci-for-jruby branch from 2564fbf to fd4f0ef Compare June 8, 2025 09:23
@ydah ydah marked this pull request as ready for review June 8, 2025 09:36
@ydah ydah requested review from headius and hsbt June 8, 2025 09:41
@headius
Copy link
Copy Markdown
Contributor

headius commented Jun 8, 2025

Sorry I missed this whole thing! I'll review.

Copy link
Copy Markdown
Contributor

@headius headius left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good!

@ydah ydah merged commit 5eb4153 into ruby:master Jun 8, 2025
31 checks passed
@ydah ydah deleted the fix-ci-for-jruby branch June 8, 2025 22:19
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

cparse-jruby.jar is not working with the latest version of JRuby

2 participants