Commit fb5277a
committed
Remove useless condition check
Since threads count is already guaranteed to be less or equal than
max_active_threads in thread_pool.rb:line 113, there is no need to
double check.
Not to mention that this will cause a race condition on the JRuby
platform, as noted in 5ac9df0.
Removing the conditional check will also reduce lock acquisitions
and improve overall efficiency.
In the original commit 1737459,
this check was essential. However, after subsequent changes,
it seems no one performed a careful review of this logic.1 parent 0fdacef commit fb5277a
1 file changed
Lines changed: 1 addition & 7 deletions
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
| |||
108 | 108 | | |
109 | 109 | | |
110 | 110 | | |
111 | | - | |
112 | | - | |
113 | | - | |
114 | | - | |
115 | | - | |
116 | | - | |
117 | 111 | | |
118 | 112 | | |
119 | 113 | | |
120 | 114 | | |
121 | 115 | | |
122 | 116 | | |
123 | | - | |
| 117 | + | |
124 | 118 | | |
125 | 119 | | |
126 | 120 | | |
| |||
0 commit comments