Skip to content

Commit 2a75d8c

Browse files
authored
Merge pull request #2871 from ksss/reduce-warning
Reduce compile warnings
2 parents f0387b7 + 2be8a57 commit 2a75d8c

File tree

3 files changed

+9
-4
lines changed

3 files changed

+9
-4
lines changed

ext/rbs_extension/ast_translation.c

Lines changed: 2 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -87,6 +87,8 @@ VALUE rbs_attr_ivar_name_to_ruby(rbs_translation_context_t ctx, rbs_attr_ivar_na
8787
return Qnil;
8888
case RBS_ATTR_IVAR_NAME_TAG_EMPTY:
8989
return Qfalse;
90+
default:
91+
rb_fatal("unknown enum rbs_attr_ivar_name_tag ivar_name.tag: %d", ivar_name.tag);
9092
}
9193
}
9294

src/parser.c

Lines changed: 4 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -519,7 +519,7 @@ static bool parse_params(rbs_parser_t *parser, method_params *params, bool self_
519519
PARSE_OPTIONAL_PARAMS:
520520
while (true) {
521521
switch (parser->next_token.type) {
522-
case pQUESTION:
522+
case pQUESTION: {
523523
rbs_parser_advance(parser);
524524

525525
if (is_keyword(parser)) {
@@ -533,6 +533,7 @@ static bool parse_params(rbs_parser_t *parser, method_params *params, bool self_
533533
rbs_node_list_append(params->optional_positionals, (rbs_node_t *) param);
534534

535535
break;
536+
}
536537
default:
537538
goto PARSE_REST_PARAM;
538539
}
@@ -597,13 +598,13 @@ static bool parse_params(rbs_parser_t *parser, method_params *params, bool self_
597598
}
598599
break;
599600

600-
case pSTAR2:
601+
case pSTAR2: {
601602
rbs_parser_advance(parser);
602603
rbs_types_function_param_t *param = NULL;
603604
CHECK_PARSE(parse_function_param(parser, &param, self_allowed, classish_allowed));
604605
params->rest_keywords = (rbs_node_t *) param;
605606
break;
606-
607+
}
607608
case tUIDENT:
608609
case tLIDENT:
609610
case tQIDENT:

templates/ext/rbs_extension/ast_translation.c.erb

Lines changed: 3 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -78,8 +78,10 @@ VALUE rbs_attr_ivar_name_to_ruby(rbs_translation_context_t ctx, rbs_attr_ivar_na
7878
}
7979
case RBS_ATTR_IVAR_NAME_TAG_UNSPECIFIED:
8080
return Qnil;
81-
case RBS_ATTR_IVAR_NAME_TAG_EMPTY:
81+
case RBS_ATTR_IVAR_NAME_TAG_EMPTY:
8282
return Qfalse;
83+
default:
84+
rb_fatal("unknown enum rbs_attr_ivar_name_tag ivar_name.tag: %d", ivar_name.tag);
8385
}
8486
}
8587

0 commit comments

Comments
 (0)