Skip to content

Commit f092bd5

Browse files
committed
Remove dead NULL branch in rbs_parse_signature
The while loop condition already guarantees next_token is kUSE, so parse_use_directive always sets use_node. The NULL check was unreachable and triggered -Wnonnull with the new nullability annotations. https://claude.ai/code/session_013XvhPzhCAZGQ9qniMY1YQY
1 parent b582767 commit f092bd5

File tree

1 file changed

+1
-5
lines changed

1 file changed

+1
-5
lines changed

src/parser.c

Lines changed: 1 addition & 5 deletions
Original file line numberDiff line numberDiff line change
@@ -3324,11 +3324,7 @@ bool rbs_parse_signature(rbs_parser_t *parser, rbs_signature_t **signature) {
33243324
rbs_ast_directives_use_t *use_node;
33253325
CHECK_PARSE(parse_use_directive(parser, &use_node));
33263326

3327-
if (use_node == NULL) {
3328-
rbs_node_list_append(dirs, NULL);
3329-
} else {
3330-
rbs_node_list_append(dirs, (rbs_node_t *) use_node);
3331-
}
3327+
rbs_node_list_append(dirs, (rbs_node_t *) use_node);
33323328
}
33333329

33343330
while (parser->next_token.type != pEOF) {

0 commit comments

Comments
 (0)