Remove unused code path from trailing_block methods#2419
Closed
st0012 wants to merge 1 commit intoruby:masterfrom
Closed
Remove unused code path from trailing_block methods#2419st0012 wants to merge 1 commit intoruby:masterfrom
st0012 wants to merge 1 commit intoruby:masterfrom
Conversation
The `trailing_block!` method is only called in one place: ``` end_loc = node.rparen_loc || node.parameters&.location || node.name_loc ``` And all three possible values for `end_loc` are of type `Prism::Location`, so the `trailing_block!` method's implementation and signature can be simplified to only handle `Prism::Location`.
Member
Author
|
Turns out @soutaro plans to use it for nodes later! So closing now 😄 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The
trailing_block!method is only called in one place:And all three possible values for
end_locare of typePrism::Location, so thetrailing_block!method's implementation and signature can be simplified to only handlePrism::Location.