Remove deprecated CLI options and inline_source

Remove the DEPRECATED options hash (--accessor, --diagram,
--inline-source, etc.), the -d/--diagram special option block,
the deprecated-option rescue/retry/warning logic, the deprecated
options section in --help output, stylesheet_url from the SPECIAL
array, and the RDoc::Task#inline_source accessors.

These have been deprecated since RDoc 4+ and users have had
ample notice.

Author: st0012

lib/rdoc/options.rb

@@ -74,23 +74,6 @@
 
 class RDoc::Options
 
-  ##
-  # The deprecated options.
-
-  DEPRECATED = {
-    '--accessor'      => 'support discontinued',
-    '--diagram'       => 'support discontinued',
-    '--help-output'   => 'support discontinued',
-    '--image-format'  => 'was an option for --diagram',
-    '--inline-source' => 'source code is now always inlined',
-    '--merge'         => 'ri now always merges class information',
-    '--one-file'      => 'support discontinued',
-    '--op-name'       => 'support discontinued',
-    '--opname'        => 'support discontinued',
-    '--promiscuous'   => 'files always only document their content',
-    '--ri-system'     => 'Ruby installers use other techniques',
-  }
-
   ##
   # RDoc options ignored (or handled specially) by --write-options
 
@@ -113,7 +96,6 @@ class RDoc::Options
     rdoc_include
     root
     static_path
-    stylesheet_url
     template
     template_dir
     update_output_dir
@@ -430,7 +412,6 @@ def init_ivars # :nodoc:
     @root = Pathname(Dir.pwd)
     @show_hash = false
     @static_path = []
-    @stylesheet_url = nil # TODO remove in RDoc 4
     @tab_width = 8
     @template = nil
     @template_dir = nil
@@ -769,14 +750,6 @@ def parse(argv)
       end
       opt.banner += "  - TomDoc:  Only in ruby files\n"
 
-      opt.banner += "\n  The following options are deprecated:\n\n"
-
-      name_length = DEPRECATED.keys.sort_by { |k| k.length }.last.length
-
-      DEPRECATED.sort_by { |k,| k }.each do |name, reason|
-        opt.banner += "    %*1$2$s  %3$s\n" % [-name_length, name, reason]
-      end
-
       opt.accept Template do |template|
         template_dir = template_dir_for template
 
@@ -1013,14 +986,6 @@ def parse(argv)
         @op_dir = value
       end
 
-      opt.separator nil
-
-      opt.on("-d",
-             "Deprecated --diagram option.",
-             "Prevents firing debug mode",
-             "with legacy invocation.") do |value|
-      end
-
       opt.separator nil
       opt.separator 'HTML generator options:'
       opt.separator nil
@@ -1230,15 +1195,12 @@ def parse(argv)
       opt.separator nil
     end
 
-    deprecated = []
     invalid = []
 
     begin
       opts.parse! argv
     rescue OptionParser::ParseError => e
-      if DEPRECATED[e.args.first] then
-        deprecated << e.args.first
-      elsif %w[--format --ri -r --ri-site -R].include? e.args.first then
+      if %w[--format --ri -r --ri-site -R].include? e.args.first then
         raise
       else
         invalid << e.args.join(' ')
@@ -1254,12 +1216,6 @@ def parse(argv)
       invalid << '-p (with files)'
     end
 
-    unless quiet then
-      deprecated.each do |opt|
-        $stderr.puts 'option ' + opt + ' is deprecated: ' + DEPRECATED[opt]
-      end
-    end
-
     unless invalid.empty? then
       invalid = "invalid options: #{invalid.join ', '}"
 

lib/rdoc/task.rb

@@ -202,21 +202,6 @@ def defaults
     @options = []
   end
 
-  ##
-  # All source is inline now.  This method is deprecated
-
-  def inline_source # :nodoc:
-    warn "RDoc::Task#inline_source is deprecated"
-    true
-  end
-
-  ##
-  # All source is inline now.  This method is deprecated
-
-  def inline_source=(value) # :nodoc:
-    warn "RDoc::Task#inline_source is deprecated"
-  end
-
   ##
   # Create the tasks defined by this task lib.
 

test/rdoc/rdoc_options_test.rb

@@ -281,21 +281,6 @@ def test_parse_default
     assert_match %r%rdoc/generator/template/aliki$%, @options.template_dir
   end
 
-  def test_parse_deprecated
-    dep_hash = RDoc::Options::DEPRECATED
-    options = dep_hash.keys.sort
-
-    out, err = capture_output do
-      @options.parse options
-    end
-
-    dep_hash.each_pair do |opt, message|
-      assert_match %r%.*#{opt}.+#{message}%, err
-    end
-
-    assert_empty out
-  end
-
   def test_parse_dry_run
     @options.parse %w[--dry-run]
 

test/rdoc/rdoc_task_test.rb

@@ -19,24 +19,6 @@ def test_clobber_task_description
     assert_equal 'Remove RDoc HTML files', @t.clobber_task_description
   end
 
-  def test_inline_source
-    _, err = verbose_capture_output do
-      assert @t.inline_source
-    end
-
-    assert_include err, "RDoc::Task#inline_source is deprecated\n"
-
-    _, err = verbose_capture_output do
-      @t.inline_source = false
-    end
-
-    assert_include err, "RDoc::Task#inline_source is deprecated\n"
-
-    capture_output do
-      assert @t.inline_source
-    end
-  end
-
   def test_markup_option
     rdoc_task = RDoc::Task.new do |rd|
       rd.markup = "tomdoc"