Remove search_record methods from code objects

These methods were only used by the now-removed JsonIndex generator.
Each had a TODO comment noting they should be removed after dropping
Darkfish/JsonIndex. The Aliki search index uses search_snippet instead.

- Remove ClassModule#search_record
- Remove TopLevel#search_record
- Remove MethodAttr#search_record
- Remove corresponding tests

Author: st0012

lib/rdoc/code_object/class_module.rb

@@ -723,24 +723,6 @@ def remove_things(my_things, other_files) # :nodoc:
     end
   end
 
-  ##
-  # Search record used by RDoc::Generator::JsonIndex
-  #
-  # TODO: Remove this method after dropping the darkfish theme and JsonIndex generator.
-  # Use #search_snippet instead for getting documentation snippets.
-
-  def search_record
-    [
-      name,
-      full_name,
-      full_name,
-      '',
-      path,
-      '',
-      snippet(@comment_location),
-    ]
-  end
-
   ##
   # Returns an HTML snippet of the first comment for search results.
 

lib/rdoc/code_object/method_attr.rb

@@ -372,25 +372,6 @@ def pretty_print(q) # :nodoc:
     end
   end
 
-  ##
-  # Used by RDoc::Generator::JsonIndex to create a record for the search
-  # engine.
-  #
-  # TODO: Remove this method after dropping the darkfish theme and JsonIndex generator.
-  # Use #search_snippet instead for getting documentation snippets.
-
-  def search_record
-    [
-      @name,
-      full_name,
-      @name,
-      @parent.full_name,
-      path,
-      params,
-      search_snippet,
-    ]
-  end
-
   ##
   # Returns an HTML snippet of the comment for search results.
 

lib/rdoc/code_object/top_level.rb

@@ -243,26 +243,6 @@ def pretty_print(q) # :nodoc:
     end
   end
 
-  ##
-  # Search record used by RDoc::Generator::JsonIndex
-  #
-  # TODO: Remove this method after dropping the darkfish theme and JsonIndex generator.
-  # Use #search_snippet instead for getting documentation snippets.
-
-  def search_record
-    return unless @parser < RDoc::Parser::Text
-
-    [
-      page_name,
-      '',
-      page_name,
-      '',
-      path,
-      '',
-      search_snippet,
-    ]
-  end
-
   ##
   # Returns an HTML snippet of the comment for search results.
 

test/rdoc/code_object/class_module_test.rb

@@ -1251,39 +1251,6 @@ def test_remove_nodoc_children
     assert_equal %w[D], parent.classes_hash.keys
   end
 
-  def test_search_record
-    @c2_c3.add_comment 'This is a comment.', @xref_data
-
-    expected = [
-      'C3',
-      'C2::C3',
-      'C2::C3',
-      '',
-      'C2/C3.html',
-      '',
-      "<p>This is a comment.\n"
-    ]
-
-    assert_equal expected, @c2_c3.search_record
-  end
-
-  def test_search_record_merged
-    @c2_c3.add_comment 'comment A', @store.add_file('a.rb')
-    @c2_c3.add_comment 'comment B', @store.add_file('b.rb')
-
-    expected = [
-      'C3',
-      'C2::C3',
-      'C2::C3',
-      '',
-      'C2/C3.html',
-      '',
-      "<p>comment A\n<p>comment B\n"
-    ]
-
-    assert_equal expected, @c2_c3.search_record
-  end
-
   def test_store_equals
     # version 2
     loaded = Marshal.load "\x04\bU:\x16RDoc::NormalClass[\x0Fi\aI\"\nKlass" +

test/rdoc/code_object/method_attr_test.rb

@@ -124,22 +124,6 @@ def test_is_alias_for
     assert_equal @c2_b, @c2_a.is_alias_for
   end
 
-  def test_search_record
-    @c1_m.comment = 'This is a comment.'
-
-    expected = [
-      'm',
-      'C1#m',
-      'm',
-      'C1',
-      'C1.html#method-i-m',
-      '(foo)',
-      "<p>This is a comment.\n",
-    ]
-
-    assert_equal expected, @c1_m.search_record
-  end
-
   def test_spaceship_returns_nil_on_inappropriate_types
     assert_nil @c1_m.<=>(RDoc::CodeObject.new)
   end

test/rdoc/parser/ruby_test.rb

@@ -2991,10 +2991,6 @@ def blah
 
     foo = @top_level.classes.first
     assert_equal 'Foo', foo.full_name
-
-    blah = foo.method_list.first
-    markup_comment = blah.search_record[6]
-    assert_equal expected, markup_comment
   end
 
   def test_parse_require_dynamic_string

test/rdoc/rdoc_top_level_test.rb

@@ -277,48 +277,6 @@ def test_page_name_trim_extension
     assert_equal 'README', tl.page_name
   end
 
-  def test_search_record
-    assert_nil @xref_data.search_record
-  end
-
-  def test_search_record_page
-    page = @store.add_file 'README.txt'
-    page.parser = RDoc::Parser::Simple
-    page.comment = 'This is a comment.'
-
-    expected = [
-      'README',
-      '',
-      'README',
-      '',
-      'README_txt.html',
-      '',
-      "<p>This is a comment.\n",
-    ]
-
-    assert_equal expected, page.search_record
-  end
-
-  def test_search_record_main_page
-    page = @store.add_file 'README.txt'
-    page.parser = RDoc::Parser::Simple
-    page.comment = 'This is a comment.'
-
-    @options.main_page = 'README.txt'
-
-    expected = [
-      'README',
-      '',
-      'README',
-      '',
-      'index.html',
-      '',
-      "<p>This is a comment.\n",
-    ]
-
-    assert_equal expected, page.search_record
-  end
-
   def test_text_eh
     refute @xref_data.text?