Respect --template flag for custom theme support

The standalone Aliki generator was hardcoding @template_dir to
its own template directory, ignoring @options.template_dir. This
broke the --template flag, preventing third-party themes like
rorvswild-theme-rdoc from rendering with their own templates.

- Use @options.template_dir instead of hardcoded path
- Generalize write_style_sheet to copy css/, js/, fonts/, and
  images/ subdirectories so custom templates with fonts and extra
  assets work correctly

Author: st0012

lib/rdoc/generator/aliki.rb

@@ -93,7 +93,7 @@ def initialize(store, options)
     @base_dir       = Pathname.pwd.expand_path
     @dry_run        = @options.dry_run
     @file_output    = true
-    @template_dir   = Pathname.new(File.expand_path(File.join(__dir__, 'template', 'aliki')))
+    @template_dir   = Pathname.new(@options.template_dir)
     @template_cache = {}
 
     @classes = nil
@@ -120,27 +120,26 @@ def gen_sub_directories
   end
 
   ##
-  # Copy only the static assets required by Aliki.
-  # Aliki does not ship embedded fonts or image sprites, keeping
-  # generated documentation lightweight.
+  # Copy static assets (CSS, JS, fonts) from the template directory
+  # to the output directory.
 
   def write_style_sheet
-    debug_msg "Copying Aliki static files"
+    debug_msg "Copying static files"
     options = { verbose: $DEBUG_RDOC, noop: @dry_run }
 
-    install_rdoc_static_file @template_dir + 'css/rdoc.css', "./css/rdoc.css", options
+    %w[css js fonts images].each do |subdir|
+      Dir[(@template_dir + "#{subdir}/**/*").to_s].each do |path|
+        next if File.directory?(path)
+        next if File.basename(path).start_with?('.')
 
-    unless @options.template_stylesheets.empty?
-      FileUtils.cp @options.template_stylesheets, '.', **options
-    end
-
-    Dir[(@template_dir + 'js/**/*').to_s].each do |path|
-      next if File.directory?(path)
-      next if File.basename(path).start_with?('.')
+        dst = Pathname.new(path).relative_path_from(@template_dir)
 
-      dst = Pathname.new(path).relative_path_from(@template_dir)
+        install_rdoc_static_file @template_dir + path, dst, options
+      end
+    end
 
-      install_rdoc_static_file @template_dir + path, dst, options
+    unless @options.template_stylesheets.empty?
+      FileUtils.cp @options.template_stylesheets, '.', **options
     end
   end
 

test/rdoc/generator/aliki_test.rb

@@ -61,7 +61,7 @@ def teardown
 
   def test_template_dir
     assert_kind_of RDoc::Generator::Aliki, @g
-    assert_match %r{/template/aliki\z}, @g.template_dir.to_s
+    assert_match %r{/template/aliki/?$}, @g.template_dir.to_s
   end
 
   def test_aliased_classes_full_name